Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: setup integration test in github workflow #19

Merged
merged 2 commits into from
Aug 30, 2021
Merged

test: setup integration test in github workflow #19

merged 2 commits into from
Aug 30, 2021

Conversation

xiongjiwei
Copy link
Contributor

  • use go-integration-test to test the FTP server
  • change the port to 2121 in config/config.example.toml temporary, after implementing command line flag, change it back.
  • only test memory-storage for now, should support other storage

@xiongjiwei xiongjiwei requested a review from a team August 28, 2021 12:40
Xuanwo
Xuanwo reviewed Aug 29, 2021
View reviewed changes
.github/workflows/integration-test.yml Outdated Show resolved Hide resolved
.github/workflows/unit-test.yml Outdated Show resolved Hide resolved
@xiongjiwei xiongjiwei requested a review from Xuanwo August 29, 2021 12:18
@Xuanwo Xuanwo mentioned this pull request Aug 30, 2021
Closed
@Xuanwo Xuanwo merged commit 925204b into beyondstorage:master Aug 30, 2021
@Xuanwo Xuanwo mentioned this pull request Sep 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xiongjiwei @Xuanwo