Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement copy dir support #73

Merged
merged 3 commits into from
Oct 14, 2021
Merged

feat: Implement copy dir support #73

merged 3 commits into from
Oct 14, 2021

Conversation

abyss-w
Copy link
Contributor

@abyss-w abyss-w commented Oct 12, 2021

No description provided.

@abyss-w
Copy link
Contributor Author

abyss-w commented Oct 13, 2021

ping @Xuanwo to review.

cmd/byctl/cp.go Outdated
@@ -25,6 +27,14 @@ var cpFlags = []cli.Flag{
},
Value: "1GiB", // Use 1 GiB as the default value.
},
&cli.BoolFlag{
Name: cpFlagDirName,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

> cp --help
  -R, -r, --recursive          copy directories recursively

How about to use the same flag with cp command?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it! I think it is feasible.

@Xuanwo
Copy link
Contributor

Xuanwo commented Oct 14, 2021

Nice work!

@Xuanwo Xuanwo merged commit f990b72 into beyondstorage:master Oct 14, 2021
@abyss-w abyss-w deleted the cp branch October 14, 2021 03:28
@abyss-w abyss-w mentioned this pull request Oct 14, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants