Skip to content
This repository has been archived by the owner on Feb 7, 2024. It is now read-only.

Fix Namespace #33

Merged
merged 1 commit into from
Dec 6, 2018
Merged

Fix Namespace #33

merged 1 commit into from
Dec 6, 2018

Conversation

irazasyed
Copy link
Contributor

@irazasyed irazasyed commented Dec 6, 2018

Some classes had namespace issues and it looks like the reason we're seeing the error referred in #10 is due to the namespace being wrong here and when it tries to call, it breaks.

I ran a few tests and the StatisticsUpdated job is running fine now (Been testing for the last few hours now, no issues).

@stayallive
Copy link
Contributor

This makes perfect sense. Should have figured that out 😅 nicely spotted!

Fun fact: because OS X is case-insensitive these issues can break an entire app after renaming a file and only changing the case of the name. All fine local, donwtime on production 😎

@irazasyed
Copy link
Contributor Author

I'm surprised the Travis tests are passing? Shouldn't it be failing?

@stayallive
Copy link
Contributor

Maybe something with the composer dumped autoloader kind-off fixing it untill something special happens like in the de-serialization? (just spit-balling, no actual clue 😅)

@mpociot mpociot merged commit 5e89f3a into beyondcode:master Dec 6, 2018
@mpociot
Copy link
Member

mpociot commented Dec 6, 2018

Thank you!

@irazasyed irazasyed deleted the fix-namespace branch December 6, 2018 20:19
@irazasyed
Copy link
Contributor Author

Cool. Thanks for merging 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants