Enabled up to 65535 pieces per model #1835
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it the least intrusive way, shaders should be backward compatible to the 254 pieces (on sane GPU drivers). It might even work, needs testing.
lhog
changed the title
lhog
added
game compat
sprunk
reviewed
Dec 20, 2024
Run the game with this and seems to work fine. Do you expect this kind of testing (ie, just testing if it doesn't break previous behaviour) or do you actually need a unit with more than 256 pieces to validate the new behaviour is correct? If so, we should look for someone who can prepare that, otherwise maybe the |
Co-authored-by: sprunk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it the least intrusive way, shaders should be backward compatible to the 255 pieces (on sane GPU drivers).
It might even work, needs testing.