Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impossible commands should not be allowed by the UI or the server #3538

Open
Jazcash opened this issue Aug 8, 2024 · 2 comments
Open

Impossible commands should not be allowed by the UI or the server #3538

Jazcash opened this issue Aug 8, 2024 · 2 comments
Labels
Bug Something isn't working Widget Unsynced gameplay and UI code

Comments

@Jazcash
Copy link
Member

Jazcash commented Aug 8, 2024

Description

Units cannot issue certain commands on themselves, for example, a unit cannot reclaim itself, cannot repair itself, cannot guard itself.

A common scenario is a transport unloading a unit while the transport is on land mode. The transport will land on top of the unit which makes it very awkward to pick back up because the command for the transport to guard itself gets shown instead.

image

Arguably, transports shouldn't land directly on top of their unloaded unit, and should perhaps instead move to the side, but I think not allowing impossible commands to be issued is the more important solution because that also fixes other mishaps that players occasionally run into.

Expected Behaviour

No command should show at all.

Actual Behaviour

Impossible commands are allowed to be issued by the UI and aren't even ignored by the server. So, for example, if a player orders a constructor to guard itself before doing its next action, it will freeze and not do anything.

Reproduction steps

No response

Other

No response

@Jazcash Jazcash added the Bug Something isn't working label Aug 8, 2024
@Jazcash Jazcash changed the title Commands usuable on own unit should not show Impossible commands should not be allowed by the UI or the server Aug 8, 2024
@sprunk
Copy link
Collaborator

sprunk commented Aug 8, 2024

Drop the orders gameside. Server doesn't simulate and the engine shouldn't drop commands that can be generally meaningful but happen not to in BAR specifically.

@MeSaber
Copy link

MeSaber commented Aug 9, 2024

Transport sometimes land beside unloaded unit: https://www.twitch.tv/videos/2207888027 timestamp: 2:23

@SethDGamre SethDGamre added the Widget Unsynced gameplay and UI code label Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Widget Unsynced gameplay and UI code
Projects
None yet
Development

No branches or pull requests

4 participants