Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for specific includes and excludes #2

Open
bewuethr opened this issue Apr 2, 2020 · 3 comments
Open

Allow for specific includes and excludes #2

bewuethr opened this issue Apr 2, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@bewuethr
Copy link
Owner

bewuethr commented Apr 2, 2020

Add action parameters that allow to include and exclude specific files to be checked/ignored.

@asbjornu
Copy link

asbjornu commented May 18, 2020

Could this include the --external-sources argument? It would be great to have a with property in which all possible arguments supported by shellcheck could be configured:

- name: Shellcheck
  uses: bewuethr/shellcheck-action@v2
  with:
    external_sources: .env
    severity: info
    include: [CODE1, CODE2]
    exclude: [CODE4, CODE5]

asbjornu added a commit to SwedbankPay/git-directory-deploy that referenced this issue May 18, 2020
Replace bewuethr/shellcheck-action with reviewdog/action-shellcheck due to the former not supporting sending arguments to shellcheck:

bewuethr/shellcheck-action#2
asbjornu added a commit to SwedbankPay/git-directory-deploy that referenced this issue May 18, 2020
Replace bewuethr/shellcheck-action with reviewdog/action-shellcheck due to the former not supporting sending arguments to shellcheck:

bewuethr/shellcheck-action#2
asbjornu added a commit to SwedbankPay/git-directory-deploy that referenced this issue May 18, 2020
Replace bewuethr/shellcheck-action with reviewdog/action-shellcheck due to the former not supporting sending arguments to shellcheck:

bewuethr/shellcheck-action#2
@bewuethr
Copy link
Owner Author

@asbjornu Definitely a good suggestion 🙂 I've spun it out into its own issue. This issue here is meant to include/exclude specific files, which is more of a function of how the action finds the files to check (with a somewhat convoluted find command, that is).

@asbjornu
Copy link

I see. Since shellcheck has its own include/exclude arguments, I assumed that was it. I'll subscribe to #4 and follow up there, then. Thanks!

@bewuethr bewuethr added the enhancement New feature or request label Oct 11, 2021
@bewuethr bewuethr moved this to Todo 📝 in Hobbyist activities Oct 11, 2021
@bewuethr bewuethr removed the status in Hobbyist activities Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

2 participants