substitute after preprocessing #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cart
reviewed
Jul 17, 2023
src/compose/mod.rs
Outdated
| offset: 0, | ||
| }, | ||
| })?; | ||
| let substituted_source = self.sanitize_and_set_auto_bindings(source); |
There was a problem hiding this comment.
Is this being called twice (on the same source input) in the same function intentional?
There was a problem hiding this comment.
nope, removed, thanks.
i had some trouble with CI failures that didn't occur locally, i believe due to github treatment of \rs, so i moved the sanitize call up to the start of the function and forgot to remove the original call.
cart
approved these changes
Jul 18, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #27
perform module and item substitution after preprocessing to make sure we use the right imports.
this is a breaking change as we need to add shader defs into the public
ErrSource::Modulevariant, so that errors can be reported with the correct substitutions.