Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix example mesh2d_manual #9941

Merged
merged 3 commits into from
Oct 6, 2023
Merged

fix example mesh2d_manual #9941

merged 3 commits into from
Oct 6, 2023

Conversation

mockersf
Copy link
Member

Objective

Solution

  • Fix the example using the new RenderMesh2dInstances

@mockersf mockersf added A-Rendering Drawing game state to the screen C-Examples An addition or correction to our examples labels Sep 27, 2023
superdump
superdump requested changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@superdump superdump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think other than that one comment, this looks good.

@rparrett rparrett added this to the 0.12 milestone Oct 2, 2023
@superdump superdump added this pull request to the merge queue Oct 4, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 4, 2023
@superdump superdump added this pull request to the merge queue Oct 5, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 5, 2023
@mockersf mockersf added this pull request to the merge queue Oct 6, 2023
Merged via the queue into bevyengine:main with commit 154a490 Oct 6, 2023
21 checks passed
regnarock pushed a commit to regnarock/bevy that referenced this pull request Oct 13, 2023
@mockersf
fix example mesh2d_manual (bevyengine#9941)
42a595d 
# Objective

- After bevyengine#9903, example
`mesh2d_manual` doesn't render anything

## Solution

- Fix the example using the new `RenderMesh2dInstances`
ameknite pushed a commit to ameknite/bevy that referenced this pull request Nov 6, 2023
@mockersf @ameknite
fix example mesh2d_manual (bevyengine#9941)
16e219f 
# Objective

- After bevyengine#9903, example
`mesh2d_manual` doesn't render anything

## Solution

- Fix the example using the new `RenderMesh2dInstances`
rdrpenguin04 pushed a commit to rdrpenguin04/bevy that referenced this pull request Jan 9, 2024
@mockersf
fix example mesh2d_manual (bevyengine#9941)
03e34b3 
# Objective

- After bevyengine#9903, example
`mesh2d_manual` doesn't render anything

## Solution

- Fix the example using the new `RenderMesh2dInstances`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@superdump superdump superdump approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Examples An addition or correction to our examples
Projects
None yet
Milestone
0.12
Development

Successfully merging this pull request may close these issues.
3 participants
@mockersf @superdump @rparrett