Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

renderer init: create a detached task only on wasm, block otherwise #9830

Merged
merged 1 commit into from
Sep 19, 2023
Merged

renderer init: create a detached task only on wasm, block otherwise #9830

merged 1 commit into from
Sep 19, 2023

Conversation

mockersf
Copy link
Member

Objective

  • When initializing the renderer, Bevy currently create a detached task
  • This is needed on wasm but not on native

Solution

  • Don't create a detached task on native but block on the future

@mockersf mockersf added the A-Rendering Drawing game state to the screen label Sep 17, 2023
@mockersf mockersf mentioned this pull request Sep 17, 2023
Merged
@mockersf mockersf added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Sep 19, 2023
@mockersf mockersf added this pull request to the merge queue Sep 19, 2023
Merged via the queue into bevyengine:main with commit 401b2e7 Sep 19, 2023
24 checks passed
rdrpenguin04 pushed a commit to rdrpenguin04/bevy that referenced this pull request Jan 9, 2024
@mockersf
renderer init: create a detached task only on wasm, block otherwise (b…
1b72df3 
…evyengine#9830)

# Objective

- When initializing the renderer, Bevy currently create a detached task
- This is needed on wasm but not on native


## Solution

- Don't create a detached task on native but block on the future
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JMS55 JMS55 JMS55 approved these changes

@hymm hymm hymm approved these changes

@arendjr arendjr arendjr approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mockersf @arendjr @hymm @JMS55