-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
warn and min for different vertex count #9699
Merged
alice-i-cecile
merged 5 commits into
bevyengine:main
from
robtfm:different-vertex-count-warn
Sep 6, 2023
Merged
warn and min for different vertex count #9699
alice-i-cecile
merged 5 commits into
bevyengine:main
from
robtfm:different-vertex-count-warn
Sep 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robtfm
added
A-Rendering
Drawing game state to the screen
P-Crash
A sudden unexpected crash
labels
Sep 5, 2023
IceSentry
approved these changes
Sep 5, 2023
JMS55
reviewed
Sep 5, 2023
alice-i-cecile
requested changes
Sep 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The # Panics
doc strings on the method are no longer correct, and should be removed. In its place, we should describe the minimizing behavior.
docs of |
mockersf
approved these changes
Sep 5, 2023
alice-i-cecile
approved these changes
Sep 5, 2023
alice-i-cecile
added
the
S-Ready-For-Final-Review
This PR has been approved by the community. It's ready for a maintainer to consider merging it
label
Sep 5, 2023
rdrpenguin04
pushed a commit
to rdrpenguin04/bevy
that referenced
this pull request
Jan 9, 2024
# Objective Bevy currently crashes when meshes with different vertex counts for attributes are provided. ## Solution Instead of crashing we can warn and take the min length of all the given attributes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-Rendering
Drawing game state to the screen
P-Crash
A sudden unexpected crash
S-Ready-For-Final-Review
This PR has been approved by the community. It's ready for a maintainer to consider merging it
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Bevy currently crashes when meshes with different vertex counts for attributes are provided.
Solution
Instead of crashing we can warn and take the min length of all the given attributes.