Relax more Sync bounds on Local
#9589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
C-Bug
alice-i-cecile
approved these changes
Aug 26, 2023
alice-i-cecile
added
the
S-Ready-For-Final-Review
JoJoJet
commented
Aug 26, 2023
|
could we add a test making a Local with a !Sync? |
alice-i-cecile
removed
the
S-Ready-For-Final-Review
@JoJoJet I think we should do this, and wait on a second approval :) |
|
I have added a test :) |
alice-i-cecile
approved these changes
Aug 27, 2023
hymm
approved these changes
Aug 28, 2023
hymm
added
the
S-Ready-For-Final-Review
rdrpenguin04
pushed a commit
to rdrpenguin04/bevy
that referenced
this pull request
Jan 9, 2024
# Objective bevyengine#5483 allows for the creation of non-`Sync` locals. However, it's not actually possible to use these types as there is a `Sync` bound on the `Deref` impls. ## Solution Remove the unnecessary bounds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
#5483 allows for the creation of non-
Synclocals. However, it's not actually possible to use these types as there is aSyncbound on theDerefimpls.Solution
Remove the unnecessary bounds.