Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Copy, Clone, Debug to derived traits of ExecutorKind #9385

Merged
merged 3 commits into from
Aug 11, 2023

Conversation

urben1680
Copy link
Contributor

While being nobody other's issue as far I can tell, I want to create a trait I plan to implement on App where more than one schedule is modified.
My workaround so far was working with a closure that returns an ExecutorKind from a match of the method variable.

It makes it easier for me to being able to clone ExecutorKind and I don't see this being controversial for others working with Bevy.

I did nothing more than adding Clone to the derived traits, no migration guide needed.

(If this worked out then the GitHub editor is not too shabby.)

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

Welcome, new contributor!

Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨

@urben1680 urben1680 changed the title added Clone to derived traits of ExcutorKind Adding Clone to derived traits of ExcutorKind Aug 8, 2023
@nicopap
Copy link
Contributor

nicopap commented Aug 8, 2023

It is probably fine to derive Copy as well.

@urben1680 urben1680 changed the title Adding Clone to derived traits of ExcutorKind Adding Clone to derived traits of ExecutorKind Aug 8, 2023
@urben1680 urben1680 changed the title Adding Clone to derived traits of ExecutorKind Adding Copy, Clone to derived traits of ExecutorKind Aug 8, 2023
@nicopap nicopap added A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Aug 8, 2023
@mockersf mockersf added this pull request to the merge queue Aug 8, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 8, 2023
Copy link
Contributor

@djeedai djeedai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the consensus on throwing a Debug in there as well? Any Bevy project level recommendation? (question for maintainers)

@nicopap
Copy link
Contributor

nicopap commented Aug 10, 2023

Well too late for Debug 😄 but I would generally be in favor. It's annoying to add to a struct or dbg! for any reason otherwise.

The merge failed, so there is still time for Debug!

@urben1680 urben1680 changed the title Adding Copy, Clone to derived traits of ExecutorKind Adding Copy, Clone, Debug to derived traits of ExecutorKind Aug 10, 2023
@urben1680
Copy link
Contributor Author

For every approve I add another trait!

@mockersf mockersf added this pull request to the merge queue Aug 11, 2023
Merged via the queue into bevyengine:main with commit 5b58064 Aug 11, 2023
20 checks passed
@urben1680 urben1680 deleted the derive-clone-for-executorkind branch August 12, 2023 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants