Remove the With<Parent> query filter from bevy_ui::render::extract_uinode_borders

[ickshonpe]

Objective

Remove the With<Parent> query filter from the parent_node_query parameter of the bevy_ui::render::extract_uinode_borders function. This is a bug, the query is only used to retrieve the size of the current node's parent. We don't care if that parent node has a Parent or not.

[Selene-Amanita]

Looks good to me, but I have a naive question: when do we check the coherence of a hierarchy and when do we not do it? propagate_transforms does it for example, but maybe it's only to prevent an infinite recursion?

[mockersf]

Suggested change

	parent_node_query: Extract<Query<&Node>>,
	node_query: Extract<Query<&Node>>,

and also where it's used

[nicopap]

Well, since it's the query used to get the parent, it makes sense to be named "parent_node_query"

[mockersf]

I would prefer to name it based on what is is, not where it's used

[ickshonpe]

I would prefer to name it based on what is is, not where it's used

agreed I think, but keep the name parent_node for the value retrieved from the query, where it is the actual Node component of the parent.

[james7132]

propagate_transforms does it for example, but maybe it's only to prevent an infinite recursion?

It does it because it would be unsound use of unsafe if the hierarchy is improperly structured, due to the mutable access on multiple threads.

[ickshonpe]

Looks good to me, but I have a naive question: when do we check the coherence of a hierarchy and when do we not do it? propagate_transforms does it for example, but maybe it's only to prevent an infinite recursion?

There are also checks in UiSurface::get_layout and UiSurface::update_children but they probably aren't sufficient for identifying all the possible problems. I think we still just panic if a node in the middle of the UI layout tree is removed without removing its descendants as well.

[alice-i-cecile]

@ickshonpe I think the rename was incomplete: CI failures look real. Once CI is passing this will be merged!

[ickshonpe]

Ah yep I see, I'll fix it now.