Update bevy_window::PresentMode to mirror wgpu::PresentMode
#9230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
A-Rendering
| @@ -819,30 +820,67 @@ pub enum PresentMode { | |||
| /// Chooses FifoRelaxed -> Fifo based on availability. | |||
| /// | |||
| /// Because of the fallback behavior, it is supported everywhere. | |||
| AutoVsync = 0, | |||
| AutoVsync = 0, // NOTE: The explicit ordinal values mirror wgpu. | |||
alice-i-cecile
approved these changes
Jul 21, 2023
alice-i-cecile
added
the
M-Needs-Migration-Guide
mockersf
approved these changes
Jul 21, 2023
mockersf
added
the
S-Ready-For-Final-Review
cart
pushed a commit
that referenced
this pull request
Aug 10, 2023
# Objective - Update `bevy_window::PresentMode` to mirror `wgpu::PresentMode`, Fixes #9151. ## Solution Add `bevy_window::PresentMode::FifoRelaxed` to `bevy_window::PresentMode`, add documents. --- ## Changelog ### Added - Add `bevy_window::PresentMode::FifoRelaxed` to `bevy_window::PresentMode`. ## Migration Guide - Handle `bevy_window::PresentMode::FifoRelaxed` when tweaking window present mode manually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
bevy_window::PresentModeto mirrorwgpu::PresentMode, Fixesbevy_window::PresentMode: The documentation for theAutoVsyncandAutoNoVsyncvariants causes confusion. #9151.Solution
Add
bevy_window::PresentMode::FifoRelaxedtobevy_window::PresentMode, add documents.Changelog
Added
bevy_window::PresentMode::FifoRelaxedtobevy_window::PresentMode.Migration Guide
bevy_window::PresentMode::FifoRelaxedwhen tweaking window present mode manually.