Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable MSAA for pixel_perfect example #9185

Closed
wants to merge 4 commits into from
Closed

Disable MSAA for pixel_perfect example #9185

wants to merge 4 commits into from

Conversation

lewiszlw
Copy link
Member

@mockersf
Copy link
Member

Disabling msaa doesn't really feel like fixing the problem but more hiding it. This doesn't happens for everyone, but only for some users on linux I think

If that's the way we want to go, a comment is needed to explain why this is needed, and on which platforms

@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen C-Examples An addition or correction to our examples X-Controversial There is active debate or serious implications around merging this PR labels Jul 18, 2023
@lewiszlw
Copy link
Member Author

Added comment.

@Selene-Amanita Selene-Amanita added this to the 0.11.1 milestone Jul 24, 2023
@lewiszlw lewiszlw requested a review from mockersf July 24, 2023 10:55
@Selene-Amanita Selene-Amanita added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jul 24, 2023
@mockersf
Copy link
Member

I won't approve this PR because I don't think it's a good thing to do, but if we want to do it this PR is good

@Selene-Amanita Selene-Amanita removed the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jul 24, 2023
@cart
Copy link
Member

cart commented Aug 9, 2023

Yeah I agree with @mockersf. I don't think this is the right call. This is a bug to be fixed. Not something to be papered over in examples.

@cart cart closed this Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Selene-Amanita Selene-Amanita Selene-Amanita approved these changes

@mockersf mockersf Awaiting requested review from mockersf

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior C-Examples An addition or correction to our examples X-Controversial There is active debate or serious implications around merging this PR
Projects
None yet
Milestone
0.11.1
Development

Successfully merging this pull request may close these issues.

Disable MSAA for pixel_perfect example
5 participants
@lewiszlw @mockersf @cart @Selene-Amanita @alice-i-cecile