Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Reflect on NoFrustumCulling #8801

Merged
merged 2 commits into from
Jun 10, 2023
Merged

Implement Reflect on NoFrustumCulling #8801

merged 2 commits into from
Jun 10, 2023

Conversation

nicopap
Copy link
Contributor

@nicopap nicopap commented Jun 9, 2023 •
edited
Loading

Objective

NoFrustumCulling doesn't implement Reflect, while nothing prevents it from implementing it.

Solution

Implement Reflect for it.

Changelog

  • Add Reflect derive to NoFrustrumCulling.
  • Add FromReflect derive to Visibility.

MrGVSV
MrGVSV reviewed Jun 9, 2023
View reviewed changes
crates/bevy_render/src/view/visibility/mod.rs Outdated
@@ -157,7 +155,8 @@ pub struct VisibilityBundle {
}

/// Use this component to opt-out of built-in frustum culling for Mesh entities
#[derive(Component)]
#[derive(Component, Reflect, Default)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we're here, could we add FromReflect and ReflectFromReflect derive and registration?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. I also found out Visibility could do with FromReflect.

@MrGVSV MrGVSV added A-Rendering Drawing game state to the screen C-Usability A targeted quality-of-life change that makes Bevy easier to use A-Reflection Runtime information about types labels Jun 9, 2023
@MrGVSV MrGVSV added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jun 10, 2023
@mockersf mockersf added this pull request to the merge queue Jun 10, 2023
Merged via the queue into bevyengine:main with commit c1fd505 Jun 10, 2023
@nicopap nicopap deleted the reflect-no-frustrum-culling branch August 30, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mockersf mockersf mockersf approved these changes

@tim-blackbird tim-blackbird tim-blackbird approved these changes

@MrGVSV MrGVSV MrGVSV approved these changes

Assignees
No one assigned
Labels
A-Reflection Runtime information about types A-Rendering Drawing game state to the screen C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
Reflection
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nicopap @mockersf @tim-blackbird @MrGVSV