Add new and map methods to Ref
#8797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrGVSV
approved these changes
Jun 9, 2023
Co-authored-by: Gino Valente <[email protected]>
alice-i-cecile
added
A-ECS
alice-i-cecile
approved these changes
Jun 9, 2023
alice-i-cecile
added
the
S-Ready-For-Final-Review
james7132
reviewed
Jun 9, 2023
| value: f(self.value), | ||
| ticks: self.ticks, | ||
| } | ||
| } |
There was a problem hiding this comment.
Mind adding an extra empty line to separate these new functions.
mockersf
approved these changes
Jun 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Refis a useful way of accessing change detection data.However, unlike
Mut, it doesn't expose a constructor or even a way to go fromRef<A>toRef<B>.Such methods could be useful, for example, to 3rd party crates that want to expose change detection information in a clean way.
My use case is to map a
Ref<T>into aRef<dyn Reflect>, and keep change detection info to avoid running expansive routines.Solution
We add the
newandmapmethods. Since similar methods exist onMutwhere they are much more footgunny to use, I judged that it was acceptable to create such methods.Workaround
Currently, it's not possible to create/project
Refs. One can define their ownRefand implementChangeDetectionon it. One would then useChangeTrackersto populate the customRefwith tick data.Changelog
Ref::mapandRef::newmethods for more ergonomicRefs