measure_text_system text query fix
#8466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
C-Bug
alice-i-cecile
approved these changes
Apr 22, 2023
tim-blackbird
approved these changes
Apr 22, 2023
alice-i-cecile
added
the
S-Ready-For-Final-Review
Estus-Dev
pushed a commit
to Estus-Dev/bevy
that referenced
this pull request
Jul 10, 2023
# Objective The first query of `measure_text_system`'s `text_queries` `ParamSet` queries for all changed `Text` meaning that non-UI `Text` entities could be added to its queue. ## Solution Add a `With<Node>` query filter. --- ## Changelog changes: * Added a `With<Node>` query filter to first query of `measure_text_system`'s `text_queries` `ParamSet` to ensure that only UI node entities are added to its local queue. * Fixed comment (text is not computed on changes to style).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
The first query of
measure_text_system'stext_queriesParamSetqueries for all changedTextmeaning that non-UITextentities could be added to its queue.Solution
Add a
With<Node>query filter.Changelog
changes:
With<Node>query filter to first query ofmeasure_text_system'stext_queriesParamSetto ensure that only UI node entities are added to its local queue.