Propagate transforms in fixed update #7929
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james7132
added
A-Transform
|
We will need to add base sets to the |
|
Marking this as blocked on #7835 then. |
james7132
added
the
S-Blocked
|
won't this potentially run propagate_transforms multiple times in a frame even if a user isn't using fixed update? Or is the cost of that negligible with the change checking? |
james7132
force-pushed
the
propagate-in-fixed-update
branch
from
1d1774f
to
91ce046
Compare
JoJoJet
reviewed
Mar 21, 2023
Comment on lines
+87
to
+90
| // A set for `propagate_transforms` to mark it as ambiguous with `sync_simple_transforms`. | ||
| // Used instead of the `SystemTypeSet` as that would not allow multiple instances of the system. | ||
| #[derive(Debug, Hash, PartialEq, Eq, Clone, SystemSet)] | ||
| struct PropagateTransformsSet; |
There was a problem hiding this comment.
This should probably be a local type inside of fn propagate_in_schedule.
Comment on lines
+115
to
+126
| fn propagate_in_schedule(schedule: &mut Schedule) { | ||
| // FIXME: https://github.com/bevyengine/bevy/issues/4381 | ||
| // These systems cannot access the same entities, | ||
| // due to subtle query filtering that is not yet correctly computed in the ambiguity detector | ||
| schedule | ||
| .add_system( | ||
| sync_simple_transforms | ||
| .in_set(TransformSystem::TransformPropagate) | ||
| .ambiguous_with(PropagateTransformsSet), | ||
| ) | ||
| .add_system(propagate_transforms.in_set(PropagateTransformsSet)); | ||
| } |
There was a problem hiding this comment.
Instead of adding systems to an &mut Schedule, can you make this return a SystemConfigs struct? Then the caller would just call add_systems with the result to add both systems to a schedule.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fix #7836.
GlobalTransformis not updated inFixedUpdate.Solution
Add it to
FixedUpdate, keep the same system sets, clean up the code a bit.Changelog
Changed: Transform propagation now runs in
CoreSet::FixedUpdate.