[Merged by Bors] - Recreate tonemapping bind group if view uniforms buffer has changed #7904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geieredgar
changed the title
james7132
added
C-Bug
robtfm
approved these changes
Mar 5, 2023
superdump
approved these changes
Mar 5, 2023
bors bot
pushed a commit
that referenced
this pull request
Mar 5, 2023
…7904) # Objective - Currently, https://github.com/vleue/bevy_bistro_playground crashes when enabling shadows, because this allocates a new buffer for the view uniforms, but the `TonemappingNode` uses a cached bind group that doesn't reference the new uniform buffer. ## Solution - Check if the buffer id of the view uniforms buffer has changed and create a new bind group if it did.
|
Pull request successfully merged into main. Build succeeded:
|
bors
bot
changed the title
Shfty
pushed a commit
to shfty-rust/bevy
that referenced
this pull request
Mar 19, 2023
…evyengine#7904) # Objective - Currently, https://github.com/vleue/bevy_bistro_playground crashes when enabling shadows, because this allocates a new buffer for the view uniforms, but the `TonemappingNode` uses a cached bind group that doesn't reference the new uniform buffer. ## Solution - Check if the buffer id of the view uniforms buffer has changed and create a new bind group if it did.
Shfty
pushed a commit
to shfty-rust/bevy
that referenced
this pull request
Mar 19, 2023
…evyengine#7904) # Objective - Currently, https://github.com/vleue/bevy_bistro_playground crashes when enabling shadows, because this allocates a new buffer for the view uniforms, but the `TonemappingNode` uses a cached bind group that doesn't reference the new uniform buffer. ## Solution - Check if the buffer id of the view uniforms buffer has changed and create a new bind group if it did.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
TonemappingNodeuses a cached bind group that doesn't reference the new uniform buffer.Solution