[Merged by Bors] - Use consistent names for marker generics #7788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoJoJet
added
A-ECS
alice-i-cecile
approved these changes
Feb 22, 2023
|
At a glance from a quick search for |
alice-i-cecile
approved these changes
Feb 22, 2023
|
Alright, that should be the last one. |
mockersf
approved these changes
Feb 23, 2023
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Feb 23, 2023
# Objective Several places in the ECS use marker generics to avoid overlapping trait implementations, but different places alternately refer to it as `Params` and `Marker`. This is potentially confusing, since it might not be clear that the same pattern is being used. Additionally, users might be misled into thinking that the `Params` type corresponds to the `SystemParam`s of a system. ## Solution Rename `Params` to `Marker`.
|
Pull request successfully merged into main. Build succeeded:
|
bors
bot
changed the title
Shfty
pushed a commit
to shfty-rust/bevy
that referenced
this pull request
Mar 19, 2023
# Objective Several places in the ECS use marker generics to avoid overlapping trait implementations, but different places alternately refer to it as `Params` and `Marker`. This is potentially confusing, since it might not be clear that the same pattern is being used. Additionally, users might be misled into thinking that the `Params` type corresponds to the `SystemParam`s of a system. ## Solution Rename `Params` to `Marker`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Several places in the ECS use marker generics to avoid overlapping trait implementations, but different places alternately refer to it as
ParamsandMarker. This is potentially confusing, since it might not be clear that the same pattern is being used. Additionally, users might be misled into thinking that theParamstype corresponds to theSystemParams of a system.Solution
Rename
ParamstoMarker.