Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Make boxed conditions read-only #7786

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Make boxed conditions read-only #7786

wants to merge 1 commit into from

Conversation

JoJoJet
Copy link
Member

@JoJoJet JoJoJet commented Feb 22, 2023

Objective

The BoxedCondition type alias does not require the underlying system to be read-only.

Solution

Define the type alias using ReadOnlySystem instead of System.

@alice-i-cecile alice-i-cecile added A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide labels Feb 22, 2023
@github-actions
Copy link
Contributor

It looks like your PR is a breaking change, but you didn't provide a migration guide.

Could you add some context on what users should update when this change get released in a new version of Bevy?
It will be used to help writing the migration guide for the version. Putting it after a ## Migration Guide will help it get automatically picked up by our tooling.

@JoJoJet
Copy link
Member Author

JoJoJet commented Feb 22, 2023

If this lands in 0.10, it will have no breaking changes.

@alice-i-cecile alice-i-cecile added this to the 0.10 milestone Feb 22, 2023
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it C-Bug An unexpected or incorrect behavior labels Feb 22, 2023
@alice-i-cecile
Copy link
Member

Merging as trivial: this is obviously correct, and everything continues to compile.

bors r+

bors bot pushed a commit that referenced this pull request Feb 22, 2023
@JoJoJet
Make boxed conditions read-only (#7786)
588af17 
# Objective

The `BoxedCondition` type alias does not require the underlying system to be read-only.

## Solution

Define the type alias using `ReadOnlySystem` instead of `System`.
@bors
Copy link
Contributor

bors bot commented Feb 22, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Make boxed conditions read-only [Merged by Bors] - Make boxed conditions read-only Feb 22, 2023
@bors bors bot closed this Feb 22, 2023
@JoJoJet JoJoJet deleted the boxed-system-type branch February 22, 2023 18:49
Shfty pushed a commit to shfty-rust/bevy that referenced this pull request Mar 19, 2023
@JoJoJet @Shfty
Make boxed conditions read-only (bevyengine#7786)
f969a06 
# Objective

The `BoxedCondition` type alias does not require the underlying system to be read-only.

## Solution

Define the type alias using `ReadOnlySystem` instead of `System`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Bug An unexpected or incorrect behavior C-Code-Quality A section of code that is hard to understand or change M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.10
Development

Successfully merging this pull request may close these issues.
2 participants
@JoJoJet @alice-i-cecile