[Merged by Bors] - expose ScheduleGraph for third party dependencies
#7522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakobhellermann
added
C-Feature
jakobhellermann
commented
Feb 6, 2023
| @@ -751,7 +878,13 @@ impl ScheduleGraph { | |||
| Ok(base_set) | |||
| } | |||
|
|
|||
| fn build_schedule( | |||
There was a problem hiding this comment.
Instead of making this (and SystemSchedule) public, we could have a method
pub fn ScheduleGraph::compute_info(&mut self) -> ScheduleGraphInfo {
// compute ambiguities, base sets, cycles, ...
// caches dependency_flattened etc.
}
fn ScheduleGraph::build_schedule(&self, &Components, ScheduleGraphInfo) -> Result<SystemSchedule, _> {}
There was a problem hiding this comment.
I think that overall I like the direction here: I can imagine future use cases where manually controlling schedule builds is helpful.
jakobhellermann
force-pushed
the
stageless-expose-schedule-graph
branch
from
19f7d37 to
c5ca453
Compare
Co-authored-by: Alice Cecile <[email protected]>
jakobhellermann
force-pushed
the
stageless-expose-schedule-graph
branch
from
c5ca453 to
baeabd6
Compare
hymm
approved these changes
Feb 13, 2023
alice-i-cecile
approved these changes
Feb 13, 2023
alice-i-cecile
added
the
S-Ready-For-Final-Review
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Feb 16, 2023
# Objective The `ScheduleGraph` should be expose so that crates like [bevy_mod_debugdump](https://github.com/jakobhellermann/bevy_mod_debugdump/blob/stageless/docs/README.md) can access useful information. ## Solution - expose `ScheduleGraph`, `NodeId`, `BaseSetMembership`, `Dag` - add accessor functions for sets and systems ## Changelog - expose `ScheduleGraph` for use in third party tools This does expose our use of `petgraph` as a graph library, so we can only change that as a breaking change.
|
Pull request successfully merged into main. Build succeeded:
|
bors
bot
changed the title
ScheduleGraph for third party dependenciesScheduleGraph for third party dependencies
myreprise1
pushed a commit
to myreprise1/bevy
that referenced
this pull request
Feb 16, 2023
# Objective The `ScheduleGraph` should be expose so that crates like [bevy_mod_debugdump](https://github.com/jakobhellermann/bevy_mod_debugdump/blob/stageless/docs/README.md) can access useful information. ## Solution - expose `ScheduleGraph`, `NodeId`, `BaseSetMembership`, `Dag` - add accessor functions for sets and systems ## Changelog - expose `ScheduleGraph` for use in third party tools This does expose our use of `petgraph` as a graph library, so we can only change that as a breaking change.
bors bot
pushed a commit
that referenced
this pull request
Feb 17, 2023
# Objective - other tools (bevy_mod_debugdump) would like to have access to the ambiguities so that they can do their own reporting/visualization ## Solution - store `conflicting_systems` in `ScheduleGraph` after calling `build_schedule` The solution isn't very pretty and as pointed out it #7522, there may be a better way of exposing this, but this is the quick and dirty way if we want to have this functionality exposed in 0.10.
myreprise1
pushed a commit
to myreprise1/bevy
that referenced
this pull request
Feb 18, 2023
# Objective - other tools (bevy_mod_debugdump) would like to have access to the ambiguities so that they can do their own reporting/visualization ## Solution - store `conflicting_systems` in `ScheduleGraph` after calling `build_schedule` The solution isn't very pretty and as pointed out it bevyengine#7522, there may be a better way of exposing this, but this is the quick and dirty way if we want to have this functionality exposed in 0.10.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
The
ScheduleGraphshould be expose so that crates like bevy_mod_debugdump can access useful information.Solution
ScheduleGraph,NodeId,BaseSetMembership,DagChangelog
ScheduleGraphfor use in third party toolsThis does expose our use of
petgraphas a graph library, so we can only change that as a breaking change.