Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Implement ReadOnlySystemParam for Extract<> #7182

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - Implement ReadOnlySystemParam for Extract<> #7182

wants to merge 3 commits into from

Conversation

JoJoJet
Copy link
Member

@JoJoJet JoJoJet commented Jan 13, 2023

Objective

Solution

Implement the trait.

@hymm hymm mentioned this pull request Jan 13, 2023
Closed
@JoJoJet JoJoJet added A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use C-Feature A new feature, making something new possible A-Rendering Drawing game state to the screen and removed C-Usability A targeted quality-of-life change that makes Bevy easier to use A-ECS Entities, components, systems, and events labels Jan 13, 2023
DJMcNab
DJMcNab reviewed Jan 13, 2023
View reviewed changes
Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't particularly like that this allows Extract<Extract>, but otherwise I don't see any reason to disallow this.

crates/bevy_render/src/extract_param.rs Show resolved Hide resolved
odiseo0
odiseo0 approved these changes Jan 13, 2023
View reviewed changes
Copy link

@odiseo0 odiseo0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was looking for something like this, good one

@alice-i-cecile alice-i-cecile added C-Code-Quality A section of code that is hard to understand or change C-Bug An unexpected or incorrect behavior and removed C-Feature A new feature, making something new possible C-Code-Quality A section of code that is hard to understand or change labels Jan 13, 2023
alice-i-cecile
alice-i-cecile approved these changes Jan 13, 2023
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jan 13, 2023
bors bot pushed a commit that referenced this pull request Jan 13, 2023
@JoJoJet
Implement ReadOnlySystemParam for Extract<> (#7182)
d9265db 
# Objective

- `Extract` does not implement `ReadOnlySystemParam` even though it should.
- Noticed by @hymm on discord: https://discord.com/channels/691052431525675048/749335865876021248/1063535818267963543

## Solution

Implement the trait.
@bors
Copy link
Contributor

bors bot commented Jan 13, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Implement ReadOnlySystemParam for Extract<> [Merged by Bors] - Implement ReadOnlySystemParam for Extract<> Jan 13, 2023
@bors bors bot closed this Jan 13, 2023
@JoJoJet JoJoJet deleted the read-only-extract branch January 14, 2023 04:27
alradish pushed a commit to alradish/bevy that referenced this pull request Jan 22, 2023
@JoJoJet @alradish
Implement ReadOnlySystemParam for Extract<> (bevyengine#7182)
f51a7c2 
# Objective

- `Extract` does not implement `ReadOnlySystemParam` even though it should.
- Noticed by @hymm on discord: https://discord.com/channels/691052431525675048/749335865876021248/1063535818267963543

## Solution

Implement the trait.
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@JoJoJet @ItsDoot
Implement ReadOnlySystemParam for Extract<> (bevyengine#7182)
0c5b195 
# Objective

- `Extract` does not implement `ReadOnlySystemParam` even though it should.
- Noticed by @hymm on discord: https://discord.com/channels/691052431525675048/749335865876021248/1063535818267963543

## Solution

Implement the trait.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DJMcNab DJMcNab DJMcNab left review comments

@hymm hymm hymm approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@odiseo0 odiseo0 odiseo0 approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JoJoJet @hymm @alice-i-cecile @DJMcNab @odiseo0