Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Remove needless manual default impl of ButtonBundle #6970

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Remove needless manual default impl of ButtonBundle #6970

wants to merge 1 commit into from

Conversation

nicopap
Copy link
Contributor

@nicopap nicopap commented Dec 16, 2022

Objective

  • Remove a manual impl block for something that can be derived
  • Correct a misleading doc comment.

@nicopap nicopap added C-Docs An addition or correction to our documentation A-UI Graphical user interfaces, styles, layouts, and widgets C-Code-Quality A section of code that is hard to understand or change labels Dec 16, 2022
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Dec 16, 2022
nicopap
nicopap commented Dec 16, 2022
View reviewed changes
crates/bevy_ui/src/node_bundles.rs
@@ -71,7 +71,7 @@ pub struct ImageBundle {
pub calculated_size: CalculatedSize,
/// The background color, which serves as a "fill" for this node
///
/// When combined with `UiImage`, tints the provided image.
/// Combines with `UiImage` to tint the provided image.
Copy link
Contributor Author

@nicopap nicopap Dec 16, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UiImage need a BackgroundColor, otherwise it won't render, I felt the previous phrasing implies it wasn't the case, noting that this is documentation on a field of ImageBundle

@mockersf
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Dec 20, 2022
@nicopap
Remove needless manual default impl of ButtonBundle (#6970)
141e455 
# Objective

- Remove a manual impl block for something that can be derived
- Correct a misleading doc comment.
@bors
Copy link
Contributor

bors bot commented Dec 20, 2022

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Dec 20, 2022
@nicopap
Remove needless manual default impl of ButtonBundle (#6970)
cf36cac 
# Objective

- Remove a manual impl block for something that can be derived
- Correct a misleading doc comment.
@bors
Copy link
Contributor

bors bot commented Dec 20, 2022

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Dec 20, 2022
@nicopap
Remove needless manual default impl of ButtonBundle (#6970)
3559f76 
# Objective

- Remove a manual impl block for something that can be derived
- Correct a misleading doc comment.
@bors
Copy link
Contributor

bors bot commented Dec 20, 2022

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Dec 20, 2022
@nicopap
Remove needless manual default impl of ButtonBundle (#6970)
9ba1a94 
# Objective

- Remove a manual impl block for something that can be derived
- Correct a misleading doc comment.
@bors
Copy link
Contributor

bors bot commented Dec 20, 2022

Build failed:

@james7132
Copy link
Member

bors retry

bors bot pushed a commit that referenced this pull request Dec 20, 2022
@nicopap
Remove needless manual default impl of ButtonBundle (#6970)
a5106c8 
# Objective

- Remove a manual impl block for something that can be derived
- Correct a misleading doc comment.
@bors
Copy link
Contributor

bors bot commented Dec 20, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Remove needless manual default impl of ButtonBundle [Merged by Bors] - Remove needless manual default impl of ButtonBundle Dec 20, 2022
@bors bors bot closed this Dec 20, 2022
alradish pushed a commit to alradish/bevy that referenced this pull request Jan 22, 2023
@nicopap @alradish
Remove needless manual default impl of ButtonBundle (bevyengine#6970)
3be8473 
# Objective

- Remove a manual impl block for something that can be derived
- Correct a misleading doc comment.
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@nicopap @ItsDoot
Remove needless manual default impl of ButtonBundle (bevyengine#6970)
5527f16 
# Objective

- Remove a manual impl block for something that can be derived
- Correct a misleading doc comment.
@nicopap nicopap deleted the less-default branch August 30, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoJoJet JoJoJet JoJoJet approved these changes

@mockersf mockersf mockersf approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@james7132 james7132 james7132 approved these changes

Assignees
No one assigned
Labels
A-UI Graphical user interfaces, styles, layouts, and widgets C-Code-Quality A section of code that is hard to understand or change C-Docs An addition or correction to our documentation S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nicopap @mockersf @james7132 @alice-i-cecile @JoJoJet