Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Add with_a and friends to Color #6899

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - Add with_a and friends to Color #6899

wants to merge 2 commits into from

Conversation

tim-blackbird
Copy link
Contributor

Objective

// makes clippy complain about 'taking a mutable reference to a `const` item'
let color = *Color::RED.set_a(0.5);

// Now you can do
let color = Color::RED.with_a(0.5);

Changelog

Added with_r, with_g, with_b, and with_a to Color.

TimJentzsch
TimJentzsch reviewed Dec 9, 2022
View reviewed changes
Copy link
Contributor

@TimJentzsch TimJentzsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea in general, although I would prefer to use full names like with_red, with_alpha, etc.

But maybe that's confusing when the fields themselves are also abbreviated.

crates/bevy_render/src/color/mod.rs Show resolved Hide resolved
@mockersf mockersf added A-Rendering Drawing game state to the screen C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Dec 9, 2022
@james7132 james7132 added this to the 0.10 milestone Dec 10, 2022
@tim-blackbird tim-blackbird requested a review from hymm December 11, 2022 15:15
@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Dec 11, 2022
@tim-blackbird
Add with_a and friends to Color (#6899)
ea8f746 
# Objective
```rust
// makes clippy complain about 'taking a mutable reference to a `const` item'
let color = *Color::RED.set_a(0.5);

// Now you can do
let color = Color::RED.with_a(0.5);
```

## Changelog
Added `with_r`, `with_g`, `with_b`, and `with_a` to `Color`.

Co-authored-by: devil-ira <[email protected]>
@bors
Copy link
Contributor

bors bot commented Dec 11, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Add with_a and friends to Color [Merged by Bors] - Add with_a and friends to Color Dec 11, 2022
@bors bors bot closed this Dec 11, 2022
alradish pushed a commit to alradish/bevy that referenced this pull request Jan 22, 2023
@tim-blackbird @alradish
Add with_a and friends to Color (bevyengine#6899)
995f0c0 
# Objective
```rust
// makes clippy complain about 'taking a mutable reference to a `const` item'
let color = *Color::RED.set_a(0.5);

// Now you can do
let color = Color::RED.with_a(0.5);
```

## Changelog
Added `with_r`, `with_g`, `with_b`, and `with_a` to `Color`.

Co-authored-by: devil-ira <[email protected]>
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@tim-blackbird @ItsDoot
Add with_a and friends to Color (bevyengine#6899)
14695c7 
# Objective
```rust
// makes clippy complain about 'taking a mutable reference to a `const` item'
let color = *Color::RED.set_a(0.5);

// Now you can do
let color = Color::RED.with_a(0.5);
```

## Changelog
Added `with_r`, `with_g`, `with_b`, and `with_a` to `Color`.

Co-authored-by: devil-ira <[email protected]>
@tim-blackbird tim-blackbird deleted the color-with-a branch March 13, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimJentzsch TimJentzsch TimJentzsch approved these changes

@mockersf mockersf mockersf approved these changes

@hymm hymm Awaiting requested review from hymm

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.10
Development

Successfully merging this pull request may close these issues.
6 participants
@tim-blackbird @alice-i-cecile @hymm @mockersf @TimJentzsch @james7132