-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - text aspect ratio bug fix #6825
Closed
Closed
Commits on Dec 2, 2022
-
Bevy UI was using the MeasureFunc that preserves aspect ratio for both images and text. This meant that the cross-axis of flex items containing text would be calculated incorrectly sometimes depending on how the aspect ratio of the text compared to the size of the containing node. changes: * Added parameter preserve_aspect_ratio to the upsert_leaf function. * The MeasureFunc only preserves the aspect ratio when preserve_aspect_ratio is true. * flex_node_system queries for UiImage before it calls upsert_leaf and sets preserve_aspect_ratio appropriately.
Configuration menu - View commit details
-
Copy full SHA for e37c780 - Browse repository at this point
Copy the full SHA e37c780View commit details -
Configuration menu - View commit details
-
Copy full SHA for 89e647c - Browse repository at this point
Copy the full SHA 89e647cView commit details
Commits on Dec 3, 2022
-
Instead of querying for images in flex_node_system, added a preserve_…
…aspect_ratio field to CalculatedSize which is set to true for image nodes by update_image_calculated_size_system.
Configuration menu - View commit details
-
Copy full SHA for 21e7531 - Browse repository at this point
Copy the full SHA 21e7531View commit details -
Configuration menu - View commit details
-
Copy full SHA for de4d940 - Browse repository at this point
Copy the full SHA de4d940View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8cf96a9 - Browse repository at this point
Copy the full SHA 8cf96a9View commit details
Commits on Dec 7, 2022
-
Configuration menu - View commit details
-
Copy full SHA for c0e012f - Browse repository at this point
Copy the full SHA c0e012fView commit details
Commits on Dec 9, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 8d0f1f2 - Browse repository at this point
Copy the full SHA 8d0f1f2View commit details
Commits on Dec 20, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 9bcca81 - Browse repository at this point
Copy the full SHA 9bcca81View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.