Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - text aspect ratio bug fix #6825

Closed
wants to merge 8 commits into from

Commits on Dec 2, 2022

  1. Text Aspect Ratio Bug Fix

    Bevy UI was using the MeasureFunc that preserves aspect ratio for both images and text.
    This meant that the cross-axis of flex items containing text would be calculated incorrectly sometimes
    depending on how the aspect ratio of the text compared to the size of the containing node.
    
    changes:
        * Added parameter preserve_aspect_ratio to the upsert_leaf function.
        * The MeasureFunc only preserves the aspect ratio when preserve_aspect_ratio is true.
        * flex_node_system queries for UiImage before it calls upsert_leaf
        and sets preserve_aspect_ratio appropriately.
    ickshonpe committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    e37c780 View commit details
    Browse the repository at this point in the history
  2. cargo fmt --all

    ickshonpe committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    89e647c View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2022

  1. Instead of querying for images in flex_node_system, added a preserve_…

    …aspect_ratio field to CalculatedSize which is
    
    set to true for image nodes by update_image_calculated_size_system.
    ickshonpe committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    21e7531 View commit details
    Browse the repository at this point in the history
  2. edit comment

    ickshonpe committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    de4d940 View commit details
    Browse the repository at this point in the history
  3. cargo fmt

    ickshonpe committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    8cf96a9 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2022

  1. Configuration menu
    Copy the full SHA
    c0e012f View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2022

  1. Configuration menu
    Copy the full SHA
    8d0f1f2 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2022

  1. Configuration menu
    Copy the full SHA
    9bcca81 View commit details
    Browse the repository at this point in the history