Add default for texture format #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuajbouw
reviewed
Oct 14, 2020
There was a problem hiding this comment.
Saw the discussion about this in chat. Makes perfect sense to have this improvement. Though, I'm not sure if having a cfg! check in default is the correct "rusty way" to do things. Typically you would want the cfg! say, for the entire function itself or in a function to choose whats right. Typically you would want the Default to be consistent across platforms I would think.
Though, consensus seems to say its ok in Rust chat.
|
Please rebase |
enfipy
force-pushed
the
add-default-for-texture-format
branch
from
b44b38e to
ffa6d5b
Compare
|
Done. Also, I updated |
|
The compiler yells at us when we try to impl From or Into for these types:
|
Closed
joshuajbouw
pushed a commit
to joshuajbouw/bevy
that referenced
this pull request
Oct 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some android devices can't work with Bgra TextureFormat - so we can replace it with
default()that will return TextureFormat depending on the target os.