[Merged by Bors] - Remove BuildWorldChildren impl from WorldChildBuilder
#6727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
C-Code-Quality
alice-i-cecile
approved these changes
Nov 22, 2022
Carter0
reviewed
Nov 22, 2022
| push_child_unchecked(self.world, parent_entity, entity); | ||
| self.current_entity = Some(entity); | ||
| let entity = self.world.spawn(Parent(self.parent)).id(); | ||
| push_child_unchecked(self.world, self.parent, entity); | ||
| if let Some(mut added) = self.world.get_resource_mut::<Events<HierarchyEvent>>() { |
There was a problem hiding this comment.
Are event's resources?
Why not just send the event, isn't a child always being added?
There was a problem hiding this comment.
The if let here is checking if the event resource itself exists (to reduce random panics).
Carter0
approved these changes
Nov 22, 2022
james7132
approved these changes
Nov 22, 2022
james7132
added
the
S-Ready-For-Final-Review
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Nov 23, 2022
# Objective
Remove an obscure and inconsistent bit of API.
Simplify the `WorldChildBuilder` code.
No idea why this even exists.
An example of the removed API:
```rust
world.spawn_empty().with_children(|parent| {
parent.spawn_empty();
parent.push_children(&[some_entity]); // Does *not* add children to the parent.
// It's actually identical to:
parent.spawn_empty().push_children(&[some_entity]);
});
world.spawn_empty().with_children(|parent| {
// This just panics.
parent.push_children(&[some_entity]);
});
```
This exists only on `WorldChildBuilder`; `ChildBuilder` does not have this API.
Yeet.
## Migration Guide
Hierarchy editing methods such as `with_children` and `push_children` have been removed from `WorldChildBuilder`.
You can edit the hierarchy via `EntityMut` instead.
Co-authored-by: devil-ira <[email protected]>
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Nov 23, 2022
# Objective
Remove an obscure and inconsistent bit of API.
Simplify the `WorldChildBuilder` code.
No idea why this even exists.
An example of the removed API:
```rust
world.spawn_empty().with_children(|parent| {
parent.spawn_empty();
parent.push_children(&[some_entity]); // Does *not* add children to the parent.
// It's actually identical to:
parent.spawn_empty().push_children(&[some_entity]);
});
world.spawn_empty().with_children(|parent| {
// This just panics.
parent.push_children(&[some_entity]);
});
```
This exists only on `WorldChildBuilder`; `ChildBuilder` does not have this API.
Yeet.
## Migration Guide
Hierarchy editing methods such as `with_children` and `push_children` have been removed from `WorldChildBuilder`.
You can edit the hierarchy via `EntityMut` instead.
Co-authored-by: devil-ira <[email protected]>
bors
bot
changed the title
BuildWorldChildren impl from WorldChildBuilderBuildWorldChildren impl from WorldChildBuilder
taiyoungjang
pushed a commit
to taiyoungjang/bevy
that referenced
this pull request
Dec 15, 2022
…#6727) # Objective Remove an obscure and inconsistent bit of API. Simplify the `WorldChildBuilder` code. No idea why this even exists. An example of the removed API: ```rust world.spawn_empty().with_children(|parent| { parent.spawn_empty(); parent.push_children(&[some_entity]); // Does *not* add children to the parent. // It's actually identical to: parent.spawn_empty().push_children(&[some_entity]); }); world.spawn_empty().with_children(|parent| { // This just panics. parent.push_children(&[some_entity]); }); ``` This exists only on `WorldChildBuilder`; `ChildBuilder` does not have this API. Yeet. ## Migration Guide Hierarchy editing methods such as `with_children` and `push_children` have been removed from `WorldChildBuilder`. You can edit the hierarchy via `EntityMut` instead. Co-authored-by: devil-ira <[email protected]>
alradish
pushed a commit
to alradish/bevy
that referenced
this pull request
Jan 22, 2023
…#6727) # Objective Remove an obscure and inconsistent bit of API. Simplify the `WorldChildBuilder` code. No idea why this even exists. An example of the removed API: ```rust world.spawn_empty().with_children(|parent| { parent.spawn_empty(); parent.push_children(&[some_entity]); // Does *not* add children to the parent. // It's actually identical to: parent.spawn_empty().push_children(&[some_entity]); }); world.spawn_empty().with_children(|parent| { // This just panics. parent.push_children(&[some_entity]); }); ``` This exists only on `WorldChildBuilder`; `ChildBuilder` does not have this API. Yeet. ## Migration Guide Hierarchy editing methods such as `with_children` and `push_children` have been removed from `WorldChildBuilder`. You can edit the hierarchy via `EntityMut` instead. Co-authored-by: devil-ira <[email protected]>
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
…#6727) # Objective Remove an obscure and inconsistent bit of API. Simplify the `WorldChildBuilder` code. No idea why this even exists. An example of the removed API: ```rust world.spawn_empty().with_children(|parent| { parent.spawn_empty(); parent.push_children(&[some_entity]); // Does *not* add children to the parent. // It's actually identical to: parent.spawn_empty().push_children(&[some_entity]); }); world.spawn_empty().with_children(|parent| { // This just panics. parent.push_children(&[some_entity]); }); ``` This exists only on `WorldChildBuilder`; `ChildBuilder` does not have this API. Yeet. ## Migration Guide Hierarchy editing methods such as `with_children` and `push_children` have been removed from `WorldChildBuilder`. You can edit the hierarchy via `EntityMut` instead. Co-authored-by: devil-ira <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Remove an obscure and inconsistent bit of API.
Simplify the
WorldChildBuildercode.No idea why this even exists.
An example of the removed API:
This exists only on
WorldChildBuilder;ChildBuilderdoes not have this API.Yeet.
Migration Guide
Hierarchy editing methods such as
with_childrenandpush_childrenhave been removed fromWorldChildBuilder.You can edit the hierarchy via
EntityMutinstead.