Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Fix material alpha_mode in example global_vs_local_translation #6658

Conversation

holyfight6
Copy link
Contributor

Objective

The global_vs_local_translation example tries to use transparency to identify static cubes, but the materials of those cubes aren't transparent.

Solution

Change material alpha_mode to AlphaMode::Blend for those cubes.

@nicopap
Copy link
Contributor

nicopap commented Nov 17, 2022

global_vs_local_translation does not use transparency in any way? I'm not sure where you got this idea. I'm running the example on main and on your branch and I see no difference. Edit: I see in the toggle_movement function reference to transparency.

Could you explain better why you think adding AlphaMode::Blend is needed?

@nicopap nicopap added C-Examples An addition or correction to our examples A-Transform Translations, rotations and scales labels Nov 17, 2022
Copy link
Contributor

@nicopap nicopap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank for the update, it makes the example much clearer!

@holyfight6
Copy link
Contributor Author

@nicopap See the comments in toggle_movement system, it uses transparency to indicate which cubes can be moved

@nicopap
Copy link
Contributor

nicopap commented Nov 17, 2022

@holyfight6 It was my bad, I totally see the interest of this PR now. Thanks.

@james7132 james7132 added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Nov 25, 2022
@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Nov 28, 2022
# Objective

The global_vs_local_translation example tries to use transparency to identify static cubes, but the materials of those cubes aren't transparent.

## Solution

Change material alpha_mode to  `AlphaMode::Blend` for those cubes.
@bors
Copy link
Contributor

bors bot commented Nov 28, 2022

Build failed:

@holyfight6
Copy link
Contributor Author

The ci build failed at some PPA error, has it been fixed now?

@alice-i-cecile
Copy link
Member

Yep, looks fixed.

bors r+

bors bot pushed a commit that referenced this pull request Dec 1, 2022
# Objective

The global_vs_local_translation example tries to use transparency to identify static cubes, but the materials of those cubes aren't transparent.

## Solution

Change material alpha_mode to  `AlphaMode::Blend` for those cubes.
@bors bors bot changed the title Fix material alpha_mode in example global_vs_local_translation [Merged by Bors] - Fix material alpha_mode in example global_vs_local_translation Dec 1, 2022
@bors bors bot closed this Dec 1, 2022
@holyfight6 holyfight6 deleted the global_vs_local_translation_transparency branch December 2, 2022 01:38
@james7132 james7132 added this to the 0.10 milestone Dec 6, 2022
alradish pushed a commit to alradish/bevy that referenced this pull request Jan 22, 2023
…ngine#6658)

# Objective

The global_vs_local_translation example tries to use transparency to identify static cubes, but the materials of those cubes aren't transparent.

## Solution

Change material alpha_mode to  `AlphaMode::Blend` for those cubes.
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
…ngine#6658)

# Objective

The global_vs_local_translation example tries to use transparency to identify static cubes, but the materials of those cubes aren't transparent.

## Solution

Change material alpha_mode to  `AlphaMode::Blend` for those cubes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Transform Translations, rotations and scales C-Examples An addition or correction to our examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants