Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Fix Link in valid_parent_check_plugin.rs #6584

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Fix Link in valid_parent_check_plugin.rs #6584

wants to merge 1 commit into from

Conversation

DasLixou
Copy link
Contributor

Objective

Link doesn't get to right segment

Solution

Fix link

alice-i-cecile
alice-i-cecile approved these changes Nov 13, 2022
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and verified that the old link was bad and your new link works. Thanks!

bors r+

@alice-i-cecile alice-i-cecile added the C-Docs An addition or correction to our documentation label Nov 13, 2022
bors bot pushed a commit that referenced this pull request Nov 13, 2022
@DasLixou
Fix Link in valid_parent_check_plugin.rs (#6584)
e48c05c 
# Objective

Link doesn't get to right segment

## Solution

Fix link
@alice-i-cecile alice-i-cecile added A-ECS Entities, components, systems, and events S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Nov 13, 2022
@bors
Copy link
Contributor

bors bot commented Nov 13, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Fix Link in valid_parent_check_plugin.rs [Merged by Bors] - Fix Link in valid_parent_check_plugin.rs Nov 13, 2022
@bors bors bot closed this Nov 13, 2022
@mockersf mockersf added this to the 0.9.1 milestone Nov 14, 2022
@DasLixou DasLixou deleted the patch-1 branch November 15, 2022 13:12
@alice-i-cecile alice-i-cecile removed this from the 0.9.1 milestone Nov 26, 2022
taiyoungjang pushed a commit to taiyoungjang/bevy that referenced this pull request Dec 15, 2022
@DasLixou @taiyoungjang
Fix Link in valid_parent_check_plugin.rs (bevyengine#6584)
393241f 
# Objective

Link doesn't get to right segment

## Solution

Fix link
alradish pushed a commit to alradish/bevy that referenced this pull request Jan 22, 2023
@DasLixou @alradish
Fix Link in valid_parent_check_plugin.rs (bevyengine#6584)
4e23967 
# Objective

Link doesn't get to right segment

## Solution

Fix link
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@DasLixou @ItsDoot
Fix Link in valid_parent_check_plugin.rs (bevyengine#6584)
20895c9 
# Objective

Link doesn't get to right segment

## Solution

Fix link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Docs An addition or correction to our documentation S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DasLixou @alice-i-cecile @mockersf