Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Make WindowId::primary() const #6582

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Make WindowId::primary() const #6582

wants to merge 1 commit into from

Conversation

lewiszlw
Copy link
Member

Objective

Solution

  • simply add const to primary().

@lewiszlw lewiszlw changed the title Make WindowsId::primary() const Make WindowId::primary() const Nov 13, 2022
@alice-i-cecile alice-i-cecile added A-Windowing Platform-agnostic interface layer to run your app in C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Nov 13, 2022
@cart
Copy link
Member

cart commented Nov 14, 2022

bors r+

bors bot pushed a commit that referenced this pull request Nov 14, 2022
@lewiszlw
Make WindowId::primary() const (#6582)
8f95560 
# Objective

- fixes #6577

## Solution

- simply add `const` to `primary()`.
@bors
Copy link
Contributor

bors bot commented Nov 14, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Make WindowId::primary() const [Merged by Bors] - Make WindowId::primary() const Nov 14, 2022
@bors bors bot closed this Nov 14, 2022
taiyoungjang pushed a commit to taiyoungjang/bevy that referenced this pull request Dec 15, 2022
@lewiszlw @taiyoungjang
Make WindowId::primary() const (bevyengine#6582)
04222f5 
# Objective

- fixes bevyengine#6577

## Solution

- simply add `const` to `primary()`.
alradish pushed a commit to alradish/bevy that referenced this pull request Jan 22, 2023
@lewiszlw @alradish
Make WindowId::primary() const (bevyengine#6582)
b8cda02 
# Objective

- fixes bevyengine#6577

## Solution

- simply add `const` to `primary()`.
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@lewiszlw @ItsDoot
Make WindowId::primary() const (bevyengine#6582)
e1770b8 
# Objective

- fixes bevyengine#6577

## Solution

- simply add `const` to `primary()`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mockersf mockersf mockersf approved these changes

@jakobhellermann jakobhellermann jakobhellermann approved these changes

@tim-blackbird tim-blackbird tim-blackbird approved these changes

Assignees
No one assigned
Labels
A-Windowing Platform-agnostic interface layer to run your app in C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make WindowId::primary() const
6 participants
@lewiszlw @cart @mockersf @jakobhellermann @tim-blackbird @alice-i-cecile