Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Speed up CommandQueue by storing commands more densely #6391

Closed
wants to merge 52 commits into from
Closed

[Merged by Bors] - Speed up CommandQueue by storing commands more densely #6391

wants to merge 52 commits into from

Commits on Oct 27, 2022

  1. Store commands contiguously

    @JoJoJet
    JoJoJet committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    24b2748 View commit details
    Browse the repository at this point in the history

  2. use read_unaligned

    @JoJoJet
    JoJoJet committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    c1df95d View commit details
    Browse the repository at this point in the history

  3. add some safety comments

    @JoJoJet
    JoJoJet committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    b71240c View commit details
    Browse the repository at this point in the history

  4. optimize some repeated additions

    @JoJoJet
    JoJoJet committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    648cc38 View commit details
    Browse the repository at this point in the history

  5. use ptr methods

    @JoJoJet
    JoJoJet committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    b60f326 View commit details
    Browse the repository at this point in the history

  6. Optimize for zero-sized types

    @JoJoJet
    JoJoJet committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    70a984e View commit details
    Browse the repository at this point in the history

  7. add safety comments to buffer writes

    @JoJoJet
    JoJoJet committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    6b488fb View commit details
    Browse the repository at this point in the history

  8. Add safety comments for pointer offsets

    @JoJoJet
    JoJoJet committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    81a6d45 View commit details
    Browse the repository at this point in the history

  9. fix a word

    @JoJoJet
    JoJoJet committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    911b0fa View commit details
    Browse the repository at this point in the history

  10. add a semicolon

    @JoJoJet
    JoJoJet committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    c41cf9e View commit details
    Browse the repository at this point in the history

  11. use a pointer write instead of copy_nonoverlapping

    @JoJoJet
    JoJoJet committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    f2bf50a View commit details
    Browse the repository at this point in the history

  12. finish a comment

    @JoJoJet
    JoJoJet committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    2274cde View commit details
    Browse the repository at this point in the history

  13. use more pointer writes

    @JoJoJet
    JoJoJet committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    c5ef708 View commit details
    Browse the repository at this point in the history

  14. inline a const

    @JoJoJet
    JoJoJet committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    5939090 View commit details
    Browse the repository at this point in the history

  15. import mem

    @JoJoJet
    JoJoJet committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    ed519de View commit details
    Browse the repository at this point in the history

  16. Add a line break

    @JoJoJet
    JoJoJet committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    c0e8694 View commit details
    Browse the repository at this point in the history

  17. move set_len closer to buffer writes

    @JoJoJet
    JoJoJet committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    6ef733e View commit details
    Browse the repository at this point in the history

  18. deduplicate pointer additions

    @JoJoJet
    JoJoJet committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    ca0b703 View commit details
    Browse the repository at this point in the history

  19. make sure some consts can get folded

    @JoJoJet
    JoJoJet committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    f91f592 View commit details
    Browse the repository at this point in the history

  20. clarify a comment

    @JoJoJet
    JoJoJet committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    0b856d9 View commit details
    Browse the repository at this point in the history

  21. Rename cursor -> ptr

    @JoJoJet
    JoJoJet committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    5a16594 View commit details
    Browse the repository at this point in the history

  22. update an outdated comment

    @JoJoJet
    JoJoJet committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    435b28e View commit details
    Browse the repository at this point in the history

  23. return the size of a command from the function pointer

    @JoJoJet
    JoJoJet committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    739c45b View commit details
    Browse the repository at this point in the history

  24. make a function name more explicit

    @JoJoJet
    JoJoJet committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    601025a View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2022

  1. refactor safety invariants for fn pointers

    @JoJoJet
    JoJoJet committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    ce4d864 View commit details
    Browse the repository at this point in the history

  2. Add another safety comment

    @JoJoJet
    JoJoJet committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    a24bdcc View commit details
    Browse the repository at this point in the history

  3. Improve a comment

    @JoJoJet
    JoJoJet committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    64b1177 View commit details
    Browse the repository at this point in the history

  4. tweak some comments

    @JoJoJet
    JoJoJet committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    7c7f775 View commit details
    Browse the repository at this point in the history

  5. fix another outdated comment

    @JoJoJet
    JoJoJet committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    494240a View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2022

  1. describe the format more naturally

    @JoJoJet
    JoJoJet committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    f94d2d3 View commit details
    Browse the repository at this point in the history

  2. Improve docs for CommandQueue

    @JoJoJet
    JoJoJet committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    92e9bf5 View commit details
    Browse the repository at this point in the history

  3. improve safety comments

    @JoJoJet
    JoJoJet committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    3d24081 View commit details
    Browse the repository at this point in the history

  4. be more explicit about ZSTs

    @JoJoJet
    JoJoJet committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    16ceb57 View commit details
    Browse the repository at this point in the history

  5. Update some old comments

    @JoJoJet
    JoJoJet committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    7706eae View commit details
    Browse the repository at this point in the history

  6. add OwningPtr::read_unaligned

    @JoJoJet
    JoJoJet committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    daa6614 View commit details
    Browse the repository at this point in the history

  7. use owning pointers for commands

    @JoJoJet
    JoJoJet committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    453c6df View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2022

  1. nitpick safety comments

    @JoJoJet
    JoJoJet committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    459eaa7 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2023

  1. Merge remote-tracking branch 'upstream/main' into command-opt

    @JoJoJet
    JoJoJet committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    f469f05 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into command-opt

    @JoJoJet
    JoJoJet committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    1fecbae View commit details
    Browse the repository at this point in the history

  3. remove a duplicate fn

    @JoJoJet
    JoJoJet committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    144eb7e View commit details
    Browse the repository at this point in the history

  4. remove a turbofish

    @JoJoJet
    JoJoJet committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    8e288e9 View commit details
    Browse the repository at this point in the history

  5. reduce churn

    @JoJoJet
    JoJoJet committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    040e85d View commit details
    Browse the repository at this point in the history

  6. reduce more comment churn

    @JoJoJet
    JoJoJet committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    f7a5b7a View commit details
    Browse the repository at this point in the history

  7. copy another comment from upstream

    @JoJoJet
    JoJoJet committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    41c6183 View commit details
    Browse the repository at this point in the history

  8. use a packed struct to simplify writing

    @JoJoJet
    JoJoJet committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    4080b5a View commit details
    Browse the repository at this point in the history

  9. tweak language for a comment

    @JoJoJet
    JoJoJet committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    7ca7a54 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2023

  1. Merge remote-tracking branch 'upstream/main' into command-opt

    @JoJoJet
    JoJoJet committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    febaf23 View commit details
    Browse the repository at this point in the history

  2. rename WithMeta -> Packed

    @JoJoJet
    JoJoJet committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    bc1741c View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2023

  1. use turbofish

    @JoJoJet
    JoJoJet committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    9791ea6 View commit details
    Browse the repository at this point in the history

  2. add a comment to Packed

    @JoJoJet
    JoJoJet committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    d6f2e5c View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2023

  1. C -> packed

    @JoJoJet
    JoJoJet committed Jan 28, 2023
    Configuration menu
    Copy the full SHA
    3142fe8 View commit details
    Browse the repository at this point in the history

  2. make a safety comment more rigorous

    @JoJoJet
    JoJoJet committed Jan 28, 2023
    Configuration menu
    Copy the full SHA
    9deaee0 View commit details
    Browse the repository at this point in the history