Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Extract resources into their target location #5271

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - Extract resources into their target location #5271

wants to merge 3 commits into from

Conversation

DJMcNab
Copy link
Member

@DJMcNab DJMcNab commented Jul 10, 2022

Objective

Solution

  • Write the resource into a ResMut<R> directly.
  • Fall-back to commands if the resource hasn't been added yet.

@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen C-Performance A change motivated by improving speed, memory usage or compile times labels Jul 10, 2022
@cart
Copy link
Member

cart commented Jul 10, 2022

bors r+

bors bot pushed a commit that referenced this pull request Jul 10, 2022
@DJMcNab
Extract resources into their target location (#5271)
8de03b0 
# Objective

- Extracting resources currently always uses commands, which requires *at least* one additional move of the extracted value, as well as dynamic dispatch.
- Addresses #4402 (comment)

## Solution

- Write the resource into a `ResMut<R>` directly.
- Fall-back to commands if the resource hasn't been added yet.
@bors
Copy link
Contributor

bors bot commented Jul 10, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Extract resources into their target location [Merged by Bors] - Extract resources into their target location Jul 10, 2022
@bors bors bot closed this Jul 10, 2022
@DJMcNab DJMcNab deleted the extract branch July 11, 2022 06:09
inodentry pushed a commit to IyesGames/bevy that referenced this pull request Aug 8, 2022
@DJMcNab @inodentry
Extract resources into their target location (bevyengine#5271)
12d4a7f 
# Objective

- Extracting resources currently always uses commands, which requires *at least* one additional move of the extracted value, as well as dynamic dispatch.
- Addresses bevyengine#4402 (comment)

## Solution

- Write the resource into a `ResMut<R>` directly.
- Fall-back to commands if the resource hasn't been added yet.
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 28, 2022
@DJMcNab @james7132
Extract resources into their target location (bevyengine#5271)
d312566 
# Objective

- Extracting resources currently always uses commands, which requires *at least* one additional move of the extracted value, as well as dynamic dispatch.
- Addresses bevyengine#4402 (comment)

## Solution

- Write the resource into a `ResMut<R>` directly.
- Fall-back to commands if the resource hasn't been added yet.
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@DJMcNab @ItsDoot
Extract resources into their target location (bevyengine#5271)
31fcf37 
# Objective

- Extracting resources currently always uses commands, which requires *at least* one additional move of the extracted value, as well as dynamic dispatch.
- Addresses bevyengine#4402 (comment)

## Solution

- Write the resource into a `ResMut<R>` directly.
- Fall-back to commands if the resource hasn't been added yet.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mockersf mockersf mockersf approved these changes

@IceSentry IceSentry IceSentry approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Performance A change motivated by improving speed, memory usage or compile times
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DJMcNab @cart @IceSentry @mockersf @alice-i-cecile