Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Move primitive type registration into bevy_reflect #4844

Closed
wants to merge 1 commit into from

Conversation

CAD97
Copy link
Contributor

@CAD97 CAD97 commented May 26, 2022

Objective

  • Users of bevy_reflect probably always want primitive types registered.

Solution

  • Register them by default.

This is a minor incremental change along the path of removing catch-all functionality from bevy_core.

@alice-i-cecile alice-i-cecile added C-Code-Quality A section of code that is hard to understand or change A-Core Common functionality for all bevy apps A-Reflection Runtime information about types labels May 26, 2022
@alice-i-cecile
Copy link
Member

@CAD97 once you've rebased I'll merge this as trivial.

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label May 30, 2022
@CAD97 CAD97 force-pushed the reflect-primitives branch 2 times, most recently from 465c05e to d8c5266 Compare June 3, 2022 19:55
@CAD97 CAD97 force-pushed the reflect-primitives branch from d8c5266 to 758aa35 Compare June 3, 2022 19:56
@CAD97
Copy link
Contributor Author

CAD97 commented Jun 3, 2022

Rebased.

@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Jun 3, 2022
# Objective

- Users of bevy_reflect probably always want primitive types registered.

## Solution

- Register them by default.

---

This is a minor incremental change along the path of [removing catch-all functionality from bevy_core](#2931).
@bors bors bot changed the title Move primitive type registration into bevy_reflect [Merged by Bors] - Move primitive type registration into bevy_reflect Jun 3, 2022
@bors bors bot closed this Jun 3, 2022
MDeiml pushed a commit to MDeiml/bevy that referenced this pull request Jun 4, 2022
# Objective

- Users of bevy_reflect probably always want primitive types registered.

## Solution

- Register them by default.

---

This is a minor incremental change along the path of [removing catch-all functionality from bevy_core](bevyengine#2931).
james7132 pushed a commit to james7132/bevy that referenced this pull request Jun 7, 2022
# Objective

- Users of bevy_reflect probably always want primitive types registered.

## Solution

- Register them by default.

---

This is a minor incremental change along the path of [removing catch-all functionality from bevy_core](bevyengine#2931).
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 28, 2022
# Objective

- Users of bevy_reflect probably always want primitive types registered.

## Solution

- Register them by default.

---

This is a minor incremental change along the path of [removing catch-all functionality from bevy_core](bevyengine#2931).
@CAD97 CAD97 deleted the reflect-primitives branch November 16, 2022 00:54
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
# Objective

- Users of bevy_reflect probably always want primitive types registered.

## Solution

- Register them by default.

---

This is a minor incremental change along the path of [removing catch-all functionality from bevy_core](bevyengine#2931).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Core Common functionality for all bevy apps A-Reflection Runtime information about types C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants