-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Move primitive type registration into bevy_reflect #4844
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
C-Code-Quality
A section of code that is hard to understand or change
A-Core
Common functionality for all bevy apps
A-Reflection
Runtime information about types
labels
May 26, 2022
@CAD97 once you've rebased I'll merge this as trivial. |
alice-i-cecile
approved these changes
May 30, 2022
alice-i-cecile
added
the
S-Ready-For-Final-Review
This PR has been approved by the community. It's ready for a maintainer to consider merging it
label
May 30, 2022
CAD97
force-pushed
the
reflect-primitives
branch
2 times, most recently
from
June 3, 2022 19:55
465c05e
to
d8c5266
Compare
Rebased. |
tim-blackbird
approved these changes
Jun 3, 2022
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jun 3, 2022
# Objective - Users of bevy_reflect probably always want primitive types registered. ## Solution - Register them by default. --- This is a minor incremental change along the path of [removing catch-all functionality from bevy_core](#2931).
bors
bot
changed the title
Move primitive type registration into bevy_reflect
[Merged by Bors] - Move primitive type registration into bevy_reflect
Jun 3, 2022
MDeiml
pushed a commit
to MDeiml/bevy
that referenced
this pull request
Jun 4, 2022
# Objective - Users of bevy_reflect probably always want primitive types registered. ## Solution - Register them by default. --- This is a minor incremental change along the path of [removing catch-all functionality from bevy_core](bevyengine#2931).
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Jun 7, 2022
# Objective - Users of bevy_reflect probably always want primitive types registered. ## Solution - Register them by default. --- This is a minor incremental change along the path of [removing catch-all functionality from bevy_core](bevyengine#2931).
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
# Objective - Users of bevy_reflect probably always want primitive types registered. ## Solution - Register them by default. --- This is a minor incremental change along the path of [removing catch-all functionality from bevy_core](bevyengine#2931).
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective - Users of bevy_reflect probably always want primitive types registered. ## Solution - Register them by default. --- This is a minor incremental change along the path of [removing catch-all functionality from bevy_core](bevyengine#2931).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-Core
Common functionality for all bevy apps
A-Reflection
Runtime information about types
C-Code-Quality
A section of code that is hard to understand or change
S-Ready-For-Final-Review
This PR has been approved by the community. It's ready for a maintainer to consider merging it
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution
This is a minor incremental change along the path of removing catch-all functionality from bevy_core.