bevy_core_pipeline: Merge main_pass_3d passes into one #4734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superdump
added
A-Rendering
|
I haven't tested this to see if it has any practical performance benefit on a laptop. But we should ideally test to see the performance difference before merging. |
alice-i-cecile
added
the
C-Code-Quality
|
Thanks for opening this one! :) |
|
A note that this now always runs a render pass. This should either check to see if there are any phase items in any of the phases and if not then early return, or this could be part of #4745 |
…to one They use the same configuration so merging them gives better performance, particularly on mobile, as the attachments have to be written out and read in between passes.
superdump
force-pushed
the
merge-pbr-passes
branch
from
ff76186 to
edadd96
Compare
|
I'm going to close this because a couple of use cases have come up where one may want to run something between the passes. As such, I think the right route forward is to split the opaque, alpha mask, and transparent passes to be run in different render graph nodes so that people have the flexibility to do stuff between if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They all use the same configuration so merging them gives better performance,
particularly on mobile, as the attachments have to be written out and read in
between passes.