Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - bevy_pbr: Fix ClusterConfig::None #4483

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - bevy_pbr: Fix ClusterConfig::None #4483

wants to merge 1 commit into from

Conversation

superdump
Copy link
Contributor

Objective

  • Fix ClusterConfig::None
  • This fix is from @robtfm but they didn't have time to submit it, so I am.

Solution

  • Always clear clusters and skip processing when ClusterConfig::None
  • Conditionally remove VisiblePointLights from the view if it is present

@superdump superdump added this to the Bevy 0.7 milestone Apr 15, 2022
@superdump superdump requested a review from cart April 15, 2022 13:56
@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Apr 15, 2022
@superdump superdump added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen P-Crash A sudden unexpected crash and removed S-Needs-Triage This issue needs to be labelled labels Apr 15, 2022
superdump
superdump commented Apr 15, 2022
View reviewed changes
Copy link
Contributor Author

@superdump superdump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I submitted this on behalf of @robtfm and I approve the PR.

@mockersf
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Apr 15, 2022
@robtfm
bevy_pbr: Fix ClusterConfig::None (#4483)
b809e8e 
# Objective

- Fix `ClusterConfig::None`
- This fix is from @robtfm but they didn't have time to submit it, so I am.

## Solution

- Always clear clusters and skip processing when `ClusterConfig::None`
- Conditionally remove `VisiblePointLights` from the view if it is present
@bors
Copy link
Contributor

bors bot commented Apr 15, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title bevy_pbr: Fix ClusterConfig::None [Merged by Bors] - bevy_pbr: Fix ClusterConfig::None Apr 15, 2022
@bors bors bot closed this Apr 15, 2022
aevyrie pushed a commit to aevyrie/bevy that referenced this pull request Jun 7, 2022
@robtfm @aevyrie
bevy_pbr: Fix ClusterConfig::None (bevyengine#4483)
b367af4 
# Objective

- Fix `ClusterConfig::None`
- This fix is from @robtfm but they didn't have time to submit it, so I am.

## Solution

- Always clear clusters and skip processing when `ClusterConfig::None`
- Conditionally remove `VisiblePointLights` from the view if it is present
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@robtfm @ItsDoot
bevy_pbr: Fix ClusterConfig::None (bevyengine#4483)
f03df5a 
# Objective

- Fix `ClusterConfig::None`
- This fix is from @robtfm but they didn't have time to submit it, so I am.

## Solution

- Always clear clusters and skip processing when `ClusterConfig::None`
- Conditionally remove `VisiblePointLights` from the view if it is present
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mockersf mockersf mockersf approved these changes

@cart cart Awaiting requested review from cart

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior P-Crash A sudden unexpected crash
Projects
None yet
Milestone
Bevy 0.7
Development

Successfully merging this pull request may close these issues.
3 participants
@superdump @mockersf @robtfm