Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Replace confusing links from CONTRIBUTING.md with short instruction #4369

Closed
wants to merge 3 commits into from

Conversation

tim-blackbird
Copy link
Contributor

Objective

CONTRIBUTING.md contains links to pages that are restricted to Bevy Engine Org members.
First time contributors who read CONTRIBUTING.md will end up on a confusing 404 page if they try to follow the link.

Relevant discussion: #4365

Solution

Replace links with directions to the Triage Team page.

Note

I'm not sure if assign themselves as a member is accurate. I think that is what automatically request membership was referring to, but i can't check for myself 😉

# Objective
CONTRIBUTING.md contains links to pages that are restricted to Bevy Engine Org members.
First time contributors who read CONTRIBUTING.md will end up on a confusing 404 page if they try to follow the link.

Relevant discussion: bevyengine#4365

## Solution

Replace links with directions to the page.

I'm not sure if `assign themselves as a member` is accurate. I think that is what `automatically request membership` was refers to, but i can't check for myself 😉
@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Mar 30, 2022
@tim-blackbird
Copy link
Contributor Author

CI failure seems unrelated to my PR.
Surprisingly though it is failing on this file.

How did those underscores get there?
@alice-i-cecile
Copy link
Member

Thanks!

@cart
Copy link
Member

cart commented Mar 30, 2022

bors r+

@cart
Copy link
Member

cart commented Mar 30, 2022

bors r-

@bors
Copy link
Contributor

bors bot commented Mar 30, 2022

Canceled.

@cart
Copy link
Member

cart commented Mar 30, 2022

Sorry one sec. Gonna make a quick change.

@cart
Copy link
Member

cart commented Mar 30, 2022

bors r+

bors bot pushed a commit that referenced this pull request Mar 31, 2022
…4369)

# Objective
CONTRIBUTING.md contains links to pages that are restricted to Bevy Engine Org members.
First time contributors who read CONTRIBUTING.md will end up on a confusing 404 page if they try to follow the link.

Relevant discussion: #4365

## Solution

Replace links with directions to the Triage Team page.

### Note

I'm not sure if `assign themselves as a member` is accurate. I think that is what `automatically request membership` was referring to, but i can't check for myself 😉


Co-authored-by: Carter Anderson <[email protected]>
@bors bors bot changed the title Replace confusing links from CONTRIBUTING.md with short instruction [Merged by Bors] - Replace confusing links from CONTRIBUTING.md with short instruction Mar 31, 2022
@bors bors bot closed this Mar 31, 2022
@tim-blackbird tim-blackbird deleted the patch-1 branch March 31, 2022 11:08
aevyrie pushed a commit to aevyrie/bevy that referenced this pull request Jun 7, 2022
…evyengine#4369)

# Objective
CONTRIBUTING.md contains links to pages that are restricted to Bevy Engine Org members.
First time contributors who read CONTRIBUTING.md will end up on a confusing 404 page if they try to follow the link.

Relevant discussion: bevyengine#4365

## Solution

Replace links with directions to the Triage Team page.

### Note

I'm not sure if `assign themselves as a member` is accurate. I think that is what `automatically request membership` was referring to, but i can't check for myself 😉


Co-authored-by: Carter Anderson <[email protected]>
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
…evyengine#4369)

# Objective
CONTRIBUTING.md contains links to pages that are restricted to Bevy Engine Org members.
First time contributors who read CONTRIBUTING.md will end up on a confusing 404 page if they try to follow the link.

Relevant discussion: bevyengine#4365

## Solution

Replace links with directions to the Triage Team page.

### Note

I'm not sure if `assign themselves as a member` is accurate. I think that is what `automatically request membership` was referring to, but i can't check for myself 😉


Co-authored-by: Carter Anderson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-Needs-Triage This issue needs to be labelled
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants