-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Replace confusing links from CONTRIBUTING.md with short instruction #4369
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Objective CONTRIBUTING.md contains links to pages that are restricted to Bevy Engine Org members. First time contributors who read CONTRIBUTING.md will end up on a confusing 404 page if they try to follow the link. Relevant discussion: bevyengine#4365 ## Solution Replace links with directions to the page. I'm not sure if `assign themselves as a member` is accurate. I think that is what `automatically request membership` was refers to, but i can't check for myself 😉
CI failure seems unrelated to my PR. |
How did those underscores get there?
alice-i-cecile
approved these changes
Mar 30, 2022
Thanks! |
bors r+ |
bors r- |
Canceled. |
Sorry one sec. Gonna make a quick change. |
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Mar 31, 2022
…4369) # Objective CONTRIBUTING.md contains links to pages that are restricted to Bevy Engine Org members. First time contributors who read CONTRIBUTING.md will end up on a confusing 404 page if they try to follow the link. Relevant discussion: #4365 ## Solution Replace links with directions to the Triage Team page. ### Note I'm not sure if `assign themselves as a member` is accurate. I think that is what `automatically request membership` was referring to, but i can't check for myself 😉 Co-authored-by: Carter Anderson <[email protected]>
bors
bot
changed the title
Replace confusing links from CONTRIBUTING.md with short instruction
[Merged by Bors] - Replace confusing links from CONTRIBUTING.md with short instruction
Mar 31, 2022
aevyrie
pushed a commit
to aevyrie/bevy
that referenced
this pull request
Jun 7, 2022
…evyengine#4369) # Objective CONTRIBUTING.md contains links to pages that are restricted to Bevy Engine Org members. First time contributors who read CONTRIBUTING.md will end up on a confusing 404 page if they try to follow the link. Relevant discussion: bevyengine#4365 ## Solution Replace links with directions to the Triage Team page. ### Note I'm not sure if `assign themselves as a member` is accurate. I think that is what `automatically request membership` was referring to, but i can't check for myself 😉 Co-authored-by: Carter Anderson <[email protected]>
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
…evyengine#4369) # Objective CONTRIBUTING.md contains links to pages that are restricted to Bevy Engine Org members. First time contributors who read CONTRIBUTING.md will end up on a confusing 404 page if they try to follow the link. Relevant discussion: bevyengine#4365 ## Solution Replace links with directions to the Triage Team page. ### Note I'm not sure if `assign themselves as a member` is accurate. I think that is what `automatically request membership` was referring to, but i can't check for myself 😉 Co-authored-by: Carter Anderson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
CONTRIBUTING.md contains links to pages that are restricted to Bevy Engine Org members.
First time contributors who read CONTRIBUTING.md will end up on a confusing 404 page if they try to follow the link.
Relevant discussion: #4365
Solution
Replace links with directions to the Triage Team page.
Note
I'm not sure if
assign themselves as a member
is accurate. I think that is whatautomatically request membership
was referring to, but i can't check for myself 😉