reduce how many colors are possible by limiting channels to what an u8 can hold

[mockersf]

Objective

• Fix ClearColor and Sprite same value yields different color #4356

Solution

• Limit conversion of colors to wgpu colors to what an u8 can hold instead of directly as a f64

This is not an ideal fix as it reduces what is possible to do, but having color channels in u8 is what is used in a lot of places

[alice-i-cecile]

Right, makes sense as a fix. I don't love it though; maybe the real solution is just to finally migrate to a proper color crate.

[mockersf]

not sure a proper color crate would change that, we still go through "one u8 per channel" when sending the color to gpu

[robtfm]

i disagree with this - users can send color data to the gpu in other ways too, which would no longer match if we only constrain in conversion to wgpu::Color.

if we want to enforce u8 space we should use u8s directly within the Color struct.

A less restrictive approach would be to constrain the f32s in the constructors. then we could add something like a rgb_raw constructor that doesn't constrain the f32s. (except this would only work for linear formats)

[mockersf]

I also disagree with this 🙂
I'm not even sure the original bug should be "fixed" - maybe documentation would be enough

[mockersf]

this is not meant to be merged