-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - can specify an anchor for a sprite #3463
Closed
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,4 +16,48 @@ pub struct Sprite { | |
/// An optional custom size for the sprite that will be used when rendering, instead of the size | ||
/// of the sprite's image | ||
pub custom_size: Option<Vec2>, | ||
/// [`Anchor`] point of the sprite in the world | ||
pub anchor: Anchor, | ||
} | ||
|
||
/// How a sprite is positioned relative to its [`Transform`](bevy_transform::components::Transform). | ||
/// It defaults to `Anchor::Center`. | ||
#[derive(Debug, Clone, Reflect)] | ||
#[doc(alias = "pivot")] | ||
pub enum Anchor { | ||
Center, | ||
BottomLeft, | ||
BottomCenter, | ||
BottomRight, | ||
CenterLeft, | ||
CenterRight, | ||
TopLeft, | ||
TopCenter, | ||
TopRight, | ||
/// Custom anchor point. Top left is `(-0.5, 0.5)`, center is `(0.0, 0.0)`. The value will | ||
/// be scaled with the sprite size. | ||
Custom(Vec2), | ||
} | ||
|
||
impl Default for Anchor { | ||
fn default() -> Self { | ||
Anchor::Center | ||
} | ||
} | ||
|
||
impl Anchor { | ||
pub fn as_vec(&self) -> Vec2 { | ||
match self { | ||
Anchor::Center => Vec2::ZERO, | ||
Anchor::BottomLeft => Vec2::new(-0.5, -0.5), | ||
Anchor::BottomCenter => Vec2::new(0.0, -0.5), | ||
Anchor::BottomRight => Vec2::new(0.5, -0.5), | ||
Anchor::CenterLeft => Vec2::new(-0.5, 0.0), | ||
Anchor::CenterRight => Vec2::new(0.5, 0.0), | ||
Anchor::TopLeft => Vec2::new(-0.5, 0.5), | ||
Anchor::TopCenter => Vec2::new(0.0, 0.5), | ||
Anchor::TopRight => Vec2::new(0.5, 0.5), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I really like that you provided these anchors for convenience. |
||
Anchor::Custom(point) => *point, | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a thought, but should this be (0, 0) bottom left to (1, 1) top right? I think that might be clearer for those who want to select an anchor as an absolute position using
Custom
rather than as an offset from the center point (which could also maybe play into UI stuff as well).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like that (0, 0) is the default behavior personally.
It doesn't matter much as long as it's clearly documented though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default being centered is good in my opinion as well.