Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - add tracing spans for parallel executor and system overhead #3416

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - add tracing spans for parallel executor and system overhead #3416

wants to merge 2 commits into from

Conversation

hymm
Copy link
Contributor

@hymm hymm commented Dec 23, 2021

This PR adds tracing spans for the parallel executor and system overhead.

image

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Dec 23, 2021
@hymm hymm changed the title add tracing spans for executor and system overhead add tracing spans for parallel executor and system overhead Dec 23, 2021
@alice-i-cecile alice-i-cecile added A-ECS Entities, components, systems, and events C-Performance A change motivated by improving speed, memory usage or compile times C-Usability A targeted quality-of-life change that makes Bevy easier to use and removed S-Needs-Triage This issue needs to be labelled labels Dec 23, 2021
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Dec 23, 2021
@cart
Copy link
Member

cart commented Dec 23, 2021

bors r+

bors bot pushed a commit that referenced this pull request Dec 23, 2021
@hymm
add tracing spans for parallel executor and system overhead (#3416)
851b593 
This PR adds tracing spans for the parallel executor and system overhead.

![image](https://user-images.githubusercontent.com/2180432/147172747-b78026e3-1c30-4120-92c8-693c6f1564cd.png)
@bors
Copy link
Contributor

bors bot commented Dec 23, 2021

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title add tracing spans for parallel executor and system overhead [Merged by Bors] - add tracing spans for parallel executor and system overhead Dec 23, 2021
@bors bors bot closed this Dec 23, 2021
@hymm hymm deleted the more-tracing-spans branch December 28, 2021 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mockersf mockersf mockersf approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Performance A change motivated by improving speed, memory usage or compile times C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hymm @cart @alice-i-cecile @mockersf