[Merged by Bors] - Sprite change image #3207
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
A-Assets
|
Had an issue on main where the dynamically updated image wouldn't render. This PR solves the issue, so I can confirm that it works. |
9 tasks
cart
reviewed
Nov 29, 2021
DJMcNab
force-pushed
the
sprite-change-image
branch
from
fe20f9d to
e76124b
Compare
…nline bind group creation for simplicity
|
Just pushed a commit that fixes a missing resource issue (games would panic at startup), removes an unnecessary clone, and does a couple of small style tweaks. I can confirm that "image hot reloading" now works. Nice work! |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Dec 1, 2021
# Objective - Changing the underlying image would not update a sprite ## Solution - 'Detect' if the underlying image changes to update the sprite Currently, we don't support change detection on `RenderAssets`, so we have to manually check it. This method at least maintains the bind groups when the image isn't changing. They were cached, so I assume that's important. This gives us correct behaviour here. Co-authored-by: Carter Anderson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution
Currently, we don't support change detection on
RenderAssets, so we have to manually check it.This method at least maintains the bind groups when the image isn't changing. They were cached, so I assume that's important.
This gives us correct behaviour here.