[Merged by Bors] - Faster gltf loader #3165
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Currently the tests fail because this new version panics on invalid models, whereas the old one silently accepted them. I'm not sure which method is better. |
|
I've tested before and after on the sci-fi base scene and the look the same at the pixel level from a particular viewpoint so they are likely the same. Comparing the result to see if they are identical would be good though. |
alice-i-cecile
added
A-Assets
aloucks
reviewed
Nov 21, 2021
mockersf
reviewed
Nov 21, 2021
|
Looks good to me! Just resolved @mockersf 's comment. |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Nov 22, 2021
# Objective - @superdump was having trouble with this loop in the GLTF loader. ## Solution - Make it probably linear. - Measured times: - Old: 40s, new: 200ms I'm sure there's still room for improvement. For example, I think making the nodes be in `Arc`s could be a significant gain, since currently there's duplication all the way down the tree. Co-authored-by: Carter Anderson <[email protected]>
|
Pull request successfully merged into pipelined-rendering. Build succeeded: |
parasyte
pushed a commit
to parasyte/bevy
that referenced
this pull request
Nov 25, 2021
# Objective - @superdump was having trouble with this loop in the GLTF loader. ## Solution - Make it probably linear. - Measured times: - Old: 40s, new: 200ms I'm sure there's still room for improvement. For example, I think making the nodes be in `Arc`s could be a significant gain, since currently there's duplication all the way down the tree. Co-authored-by: Carter Anderson <[email protected]>
Merged
DJMcNab
added a commit
to DJMcNab/bevy
that referenced
this pull request
Nov 25, 2021
# Objective - @superdump was having trouble with this loop in the GLTF loader. ## Solution - Make it probably linear. - Measured times: - Old: 40s, new: 200ms I'm sure there's still room for improvement. For example, I think making the nodes be in `Arc`s could be a significant gain, since currently there's duplication all the way down the tree. Co-authored-by: Carter Anderson <[email protected]>
bors bot
pushed a commit
that referenced
this pull request
Nov 25, 2021
See #3165 and #3175 # Objective - @superdump was having trouble with this loop in the GLTF loader. ## Solution - Make it probably linear. - Measured times: - Old: 40s, new: 200ms I think there's still room for improvement. For example, I think making the nodes be in `Arc`s could be a significant gain, since currently there's duplication all the way down the tree. Co-authored-by: Carter Anderson <[email protected]>
HackerFoo
pushed a commit
to HackerFoo/bevy
that referenced
this pull request
Nov 26, 2021
See bevyengine#3165 and bevyengine#3175 # Objective - @superdump was having trouble with this loop in the GLTF loader. ## Solution - Make it probably linear. - Measured times: - Old: 40s, new: 200ms I think there's still room for improvement. For example, I think making the nodes be in `Arc`s could be a significant gain, since currently there's duplication all the way down the tree. Co-authored-by: Carter Anderson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution
I'm sure there's still room for improvement. For example, I think making the nodes be in
Arcs could be a significant gain, since currently there's duplication all the way down the tree.