[Merged by Bors] - Removal detection cleanup #3010
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should check for both component removal and entity despawning.
alice-i-cecile
added
A-ECS
mockersf
reviewed
Oct 22, 2021
mockersf
reviewed
Oct 22, 2021
NiklasEi
approved these changes
Oct 23, 2021
mockersf
approved these changes
Oct 27, 2021
mockersf
added
S-Ready-For-Final-Review
mockersf
reviewed
Dec 16, 2021
| /// note that the `RemovedComponents` list will not be automatically cleared for you, | ||
| /// and will need to be manually flushed using [`World::clear_trackers`] | ||
| /// | ||
| /// For users of `bevy` itself, this is automatically done in a system added by `MinimalPlugins` |
There was a problem hiding this comment.
it should be mentioned that it's also added by DefaultPlugins, not just by MinimalPlugins
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jan 5, 2022
# Objective - Fixes #1920. - Users often want to know how to get the values of removed components (#1655). - Stand-alone `bevy_ecs` behavior is very unintuitive, as `World::clear_trackers()` must be manually called. - Fixes #2999 by extending the existing test (thanks @hymm for pointing me to it) to be clearer and check for component removal as well. ## Solution - Better docs! - Better tests!
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
bevy_ecsbehavior is very unintuitive, asWorld::clear_trackers()must be manually called.Solution