Update notify to 5.0.0-pre.13 from pre.11 #2993
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmmm... this advisory check failure seems to be unrelated. I am guessing this advisory fails on main as well |
mockersf
added
A-Assets
mockersf
approved these changes
Oct 20, 2021
|
yup the advisories are related to other dependencies, not related here |
This was referenced Nov 29, 2021
bors bot
pushed a commit
that referenced
this pull request
Dec 9, 2021
# Objective - there are a few new versions for `ron`, `winit`, `ndk`, `raw-window-handle` - `cargo-deny` is failing due to new security issues / duplicated dependencies ## Solution - Update our dependencies - Note all new security issues, with which of Bevy direct dependency it comes from - Update duplicate crate list, with which of Bevy direct dependency it comes from `notify` is not updated here as it's in #2993
| @@ -28,7 +28,7 @@ crossbeam-channel = "0.5.0" | |||
| anyhow = "1.0.4" | |||
| thiserror = "1.0" | |||
| downcast-rs = "1.2.0" | |||
| notify = { version = "=5.0.0-pre.11", optional = true } | |||
| notify = { version = "=5.0.0-pre.13", optional = true } | |||
There was a problem hiding this comment.
Suggested change
| notify = { version = "=5.0.0-pre.13", optional = true } | |
| notify = { version = "=5.0.0-pre.15", optional = true } |
alice-i-cecile
requested changes
May 16, 2022
There was a problem hiding this comment.
@deontologician bump the version number further (this went stale) and I'll be happy to merge it once you've tested to see that we didn't break hot-reloading.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
notifydep ofbevy_assetsis out of dateSolution
Bump the dependency to the latest version