[Merged by Bors] - Fix scale factor for cursor position #2932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes the wrong scale factor was used (not accounting for overrides). Fixes bevyengine#2501
mockersf
added
A-Windowing
alice-i-cecile
approved these changes
Oct 7, 2021
bjorn3
reviewed
Oct 8, 2021
IceSentry
approved these changes
Oct 8, 2021
Co-authored-by: bjorn3 <[email protected]>
mockersf
added
the
S-Ready-For-Final-Review
bjorn3
approved these changes
Oct 15, 2021
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 15, 2021
# Objective - Fixes #2501 - Builds up on #2639 taking #2639 (comment) into account ## Solution - keep the physical cursor position in `Window`, and expose it. - still convert to logical position in event, and when getting `cursor_position` Co-authored-by: Ahmed Charles <[email protected]>
bors
bot
changed the title
sharkdp
pushed a commit
to sharkdp/bevy
that referenced
this pull request
Nov 8, 2021
# Objective - Fixes bevyengine#2501 - Builds up on bevyengine#2639 taking bevyengine#2639 (comment) into account ## Solution - keep the physical cursor position in `Window`, and expose it. - still convert to logical position in event, and when getting `cursor_position` Co-authored-by: Ahmed Charles <[email protected]>
sharkdp
pushed a commit
to sharkdp/bevy
that referenced
this pull request
Dec 12, 2021
# Objective - Fixes bevyengine#2501 - Builds up on bevyengine#2639 taking bevyengine#2639 (comment) into account ## Solution - keep the physical cursor position in `Window`, and expose it. - still convert to logical position in event, and when getting `cursor_position` Co-authored-by: Ahmed Charles <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution
Window, and expose it.cursor_position