Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Better error message for unsupported shader features Fixes #869 #2598

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Better error message for unsupported shader features Fixes #869 #2598

wants to merge 1 commit into from

Conversation

myisaak
Copy link
Contributor

@myisaak myisaak commented Aug 4, 2021 •
edited
Loading

Objective

  • Provides more useful error messages when using unsupported shader features.

Solution Fixes #869

  • Provided a error message as follows (adding name, set and binding):
Unsupported shader bind type CombinedImageSampler (name noiseVol0, set 0, binding 9)

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Aug 4, 2021
@myisaak myisaak mentioned this pull request Aug 4, 2021
Closed
@myisaak myisaak force-pushed the better_error_message_for_unsupported_shader_features branch from 8ac1075 to 64a759f Compare August 4, 2021 14:53
@DJMcNab DJMcNab added A-Rendering Drawing game state to the screen C-Feature A new feature, making something new possible C-Usability A targeted quality-of-life change that makes Bevy easier to use and removed S-Needs-Triage This issue needs to be labelled labels Aug 6, 2021
@DJMcNab
Copy link
Member

DJMcNab commented Aug 6, 2021

bors try

bors bot added a commit that referenced this pull request Aug 6, 2021
@bors
Try #2598:
bbbec65
DJMcNab
DJMcNab reviewed Aug 6, 2021
View reviewed changes
Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval pending formatting being fixed

This is one of the few cases where I think rustfmt's formatting is significantly worse. However, it's still better just to stick with rustfmt's formatting.

You should be able to reformat by using

cargo fmt --all

@bors
Copy link
Contributor

bors bot commented Aug 6, 2021

try

Build succeeded:

@myisaak myisaak force-pushed the better_error_message_for_unsupported_shader_features branch from 64a759f to 347ddb7 Compare August 7, 2021 09:03
@mockersf
Copy link
Member

mockersf commented Aug 9, 2021

could you mention Fixes #869 in the PR description for github to link it?

@myisaak
Copy link
Contributor Author

myisaak commented Aug 9, 2021

Done.

@mockersf mockersf added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Aug 9, 2021
@cart
Copy link
Member

cart commented Aug 13, 2021

bors r+

bors bot pushed a commit that referenced this pull request Aug 13, 2021
@myisaak
Better error message for unsupported shader features Fixes #869 (#2598)
5eeba15 
# Objective

- Provides more useful error messages when using unsupported shader features.

## Solution Fixes #869

- Provided a error message as follows (adding name, set and binding): 
```
Unsupported shader bind type CombinedImageSampler (name noiseVol0, set 0, binding 9)
```
@bors
Copy link
Contributor

bors bot commented Aug 13, 2021

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Better error message for unsupported shader features Fixes #869 [Merged by Bors] - Better error message for unsupported shader features Fixes #869 Aug 13, 2021
@bors bors bot closed this Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DJMcNab DJMcNab DJMcNab approved these changes

@mockersf mockersf mockersf approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Feature A new feature, making something new possible C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better error messages for unsupported shading language features
4 participants
@myisaak @DJMcNab @mockersf @cart