-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - fix missing paths in ECS SystemParam derive macro v2 #2550
Conversation
bors try |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Matches the other PR; reasoning makes sense :) Looks good to me, thanks for the contribution!
tryBuild failed: |
This same problem appears to be also present in the main branch. I'm submitting this patch for 0.5.1 since that's what I'm testing with - but is there a process for porting the patches to main? The android failure appears to be a random fluke - how does one request a rebuild? |
Bevy org members can ask bors again :) Once your first PR is merged you'll also be able to trigger it with a fresh push. Oh and Cart can manually approve you.
The branching here is a new process to deal with a minor emergency (a dependency broke semver...); I'm not sure what the right call is here. Previously you'd just target main with this but this style of trivial bug fix is a good candidate for our point releases. @cart (and @mockersf) what do you think should be done here? |
The base branch should be changed to main. Your assessment of the situation is correct. We don't yet have a formal patch release process and we won't accept arbitrary PRs to the 0.5.1 release branch. We are currently discussing how / whether or not to start doing patch releases more aggressively, but until then, all new changes should target main. |
Originally authored by @woubuc
Thanks for the guidance. I've rebased the patch to main. |
@alice-i-cecile Sorry to be a bother, but could you please restart the CI? I don't want this tiny fix to get misplaced again. |
bors try |
tryBuild failed: |
unrelated error, looks good 👍 |
bors r+ |
This is an updated version of #1434 PR. I've encountered this macro problem while trying to use @woubuc's bevy-event-set crate. Co-authored-by: Piotr Balcer <[email protected]>
Timed out. |
bors r+ |
This is an updated version of #1434 PR. I've encountered this macro problem while trying to use @woubuc's bevy-event-set crate. Co-authored-by: Piotr Balcer <[email protected]>
This is an updated version of #1434 PR. I've encountered this macro problem while trying to use @woubuc's bevy-event-set crate.