Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Fix name in list of features #2438

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - Fix name in list of features #2438

wants to merge 2 commits into from

Conversation

tsoutsman
Copy link
Contributor

Objective

  • Fix the name of the bevy_dynamic_plugin feature in the list of features

Solution

  • Remove the letter "s" 😶

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Jul 6, 2021
@alice-i-cecile alice-i-cecile added C-Docs An addition or correction to our documentation and removed S-Needs-Triage This issue needs to be labelled labels Jul 6, 2021
@NathanSWard NathanSWard added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jul 6, 2021
@mockersf
Copy link
Member

mockersf commented Jul 6, 2021

Thanks for finding and fixing that typo! Could you go on #2373 and mention if you're ok with the license change?

@tim-blackbird
Copy link
Contributor

Thanks for finding and fixing that typo! Could you go on #2373 and mention if you're ok with the license change?

No need for that, I believe. Quoting #2373:

(as not all contributions qualify for copyright, due to not being a "creative work", e.g. a typo fix)

@cart
Copy link
Member

cart commented Jul 6, 2021

bors r+

bors bot pushed a commit that referenced this pull request Jul 6, 2021
@tsoutsman
Fix name in list of features (#2438)
bc3f80f 
# Objective

- Fix the name of the `bevy_dynamic_plugin` feature in the list of features

## Solution

- Remove the letter "s" 😶
@bors
Copy link
Contributor

bors bot commented Jul 6, 2021

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Fix name in list of features [Merged by Bors] - Fix name in list of features Jul 6, 2021
@bors bors bot closed this Jul 6, 2021
ostwilkens pushed a commit to ostwilkens/bevy that referenced this pull request Jul 27, 2021
@tsoutsman @ostwilkens
Fix name in list of features (bevyengine#2438)
a437dc1 
# Objective

- Fix the name of the `bevy_dynamic_plugin` feature in the list of features

## Solution

- Remove the letter "s" 😶
@dman-os dman-os mentioned this pull request Aug 15, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@mockersf mockersf mockersf approved these changes

@NathanSWard NathanSWard NathanSWard approved these changes

Assignees
No one assigned
Labels
C-Docs An addition or correction to our documentation S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tsoutsman @mockersf @tim-blackbird @cart @alice-i-cecile @NathanSWard