Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Per entity Events #2116

Closed
wants to merge 39 commits into from
Closed

Per entity Events #2116

wants to merge 39 commits into from

Commits on May 8, 2021

  1. Clean up on Examples README 

    To make it easier to add the new example. Table auto-formatted with Markdownlint VSCode extension
    @alice-i-cecile
    alice-i-cecile committed May 8, 2021
    Configuration menu
    Copy the full SHA
    525ccd5 View commit details
    Browse the repository at this point in the history

  2. Add per_entity_events stub example

    @alice-i-cecile
    alice-i-cecile committed May 8, 2021
    Configuration menu
    Copy the full SHA
    fcf73a4 View commit details
    Browse the repository at this point in the history

  3. Basic example description

    @alice-i-cecile
    alice-i-cecile committed May 8, 2021
    Configuration menu
    Copy the full SHA
    76c83a2 View commit details
    Browse the repository at this point in the history

  4. Added missing file extension

    @alice-i-cecile
    alice-i-cecile committed May 8, 2021
    Configuration menu
    Copy the full SHA
    b00edd4 View commit details
    Browse the repository at this point in the history

  5. Input dispatch example skeleton

    @alice-i-cecile
    alice-i-cecile committed May 8, 2021
    Configuration menu
    Copy the full SHA
    9119a69 View commit details
    Browse the repository at this point in the history

  6. Cleaned up InteractableBundle

    @alice-i-cecile
    alice-i-cecile committed May 8, 2021
    Configuration menu
    Copy the full SHA
    cdd98a0 View commit details
    Browse the repository at this point in the history

  7. Added lifetimes to satisfy borrow checker

    @alice-i-cecile
    alice-i-cecile committed May 8, 2021
    Configuration menu
    Copy the full SHA
    4786931 View commit details
    Browse the repository at this point in the history

  8. Added better impl plan notes

    @alice-i-cecile
    alice-i-cecile committed May 8, 2021
    Configuration menu
    Copy the full SHA
    b1bd2e5 View commit details
    Browse the repository at this point in the history

  9. Spawn InteractableBundle entities

    @alice-i-cecile
    alice-i-cecile committed May 8, 2021
    Configuration menu
    Copy the full SHA
    d36a304 View commit details
    Browse the repository at this point in the history

  10. Color updating system

    @alice-i-cecile
    alice-i-cecile committed May 8, 2021
    Configuration menu
    Copy the full SHA
    36faf02 View commit details
    Browse the repository at this point in the history

  11. Should demo how to use raw Events

    @alice-i-cecile
    alice-i-cecile committed May 8, 2021
    Configuration menu
    Copy the full SHA
    4ca4373 View commit details
    Browse the repository at this point in the history

  12. Manual event reader syntax

    @alice-i-cecile
    alice-i-cecile committed May 8, 2021
    Configuration menu
    Copy the full SHA
    f39accd View commit details
    Browse the repository at this point in the history

  13. Clear componentized Events too

    @alice-i-cecile
    alice-i-cecile committed May 8, 2021
    Configuration menu
    Copy the full SHA
    b552aaa View commit details
    Browse the repository at this point in the history

  14. Example mostly works

    @alice-i-cecile
    alice-i-cecile committed May 8, 2021
    Configuration menu
    Copy the full SHA
    3ae1b2d View commit details
    Browse the repository at this point in the history

  15. Prevent addition overflow

    @alice-i-cecile
    alice-i-cecile committed May 8, 2021
    Configuration menu
    Copy the full SHA
    eae4f97 View commit details
    Browse the repository at this point in the history

  16. Code quality cleanup

    @alice-i-cecile
    alice-i-cecile committed May 8, 2021
    Configuration menu
    Copy the full SHA
    922a298 View commit details
    Browse the repository at this point in the history

  17. Fixed double-counting by storing an EventReader

    @alice-i-cecile
    alice-i-cecile committed May 8, 2021
    Configuration menu
    Copy the full SHA
    61b0bef View commit details
    Browse the repository at this point in the history

  18. Removed left-right controls for brevity

    @alice-i-cecile
    alice-i-cecile committed May 8, 2021
    Configuration menu
    Copy the full SHA
    489294e View commit details
    Browse the repository at this point in the history

  19. Less colors, more brevity

    @alice-i-cecile
    alice-i-cecile committed May 8, 2021
    Configuration menu
    Copy the full SHA
    1b9c1cc View commit details
    Browse the repository at this point in the history

  20. Simpler input handling

    @alice-i-cecile
    alice-i-cecile committed May 8, 2021
    Configuration menu
    Copy the full SHA
    a952c1b View commit details
    Browse the repository at this point in the history

  21. Quick and easy keycode math 

    Credit to @mockersf for the idea
    @alice-i-cecile
    alice-i-cecile committed May 8, 2021
    Configuration menu
    Copy the full SHA
    45478f9 View commit details
    Browse the repository at this point in the history

  22. Foundations for EventReader etc Query parameters

    @alice-i-cecile
    alice-i-cecile committed May 8, 2021
    Configuration menu
    Copy the full SHA
    532a544 View commit details
    Browse the repository at this point in the history

  23. Nearly-working impl of EventWriter<T> components 

    Had to change EventWriter and Reader to take vanilla refs, rather than Res smart pointers to accommodate mixed resource and component usage.

Lifetimes are still sad.
    @alice-i-cecile
    alice-i-cecile committed May 8, 2021
    Configuration menu
    Copy the full SHA
    aceea35 View commit details
    Browse the repository at this point in the history

  24. Removed lifetime by storing StorageType directly 

    See bevyengine#2119 to clean this up.
    @alice-i-cecile
    alice-i-cecile committed May 8, 2021
    Configuration menu
    Copy the full SHA
    56eece5 View commit details
    Browse the repository at this point in the history

  25. Use into_inner to properly convert Mut to &mut

    @alice-i-cecile
    alice-i-cecile committed May 8, 2021
    Configuration menu
    Copy the full SHA
    77dc531 View commit details
    Browse the repository at this point in the history

  26. Add EventWriter::new() to allow for creation outside of module 

    Field should not be pub to avoid violating guarantees, so we get a constructor instead
    @alice-i-cecile
    alice-i-cecile committed May 8, 2021
    Configuration menu
    Copy the full SHA
    eda6ffa View commit details
    Browse the repository at this point in the history

  27. Removed redundant storage type in EventWriterState

    @alice-i-cecile
    alice-i-cecile committed May 8, 2021
    Configuration menu
    Copy the full SHA
    769edc1 View commit details
    Browse the repository at this point in the history

  28. Fixed visibility to make everything compile!

    @alice-i-cecile
    alice-i-cecile committed May 8, 2021
    Configuration menu
    Copy the full SHA
    92358df View commit details
    Browse the repository at this point in the history

  29. Code organization 

    Moves impl blocks directly after types, organizes like-types together, presents shared functionality first
    @alice-i-cecile
    alice-i-cecile committed May 8, 2021
    Configuration menu
    Copy the full SHA
    4b6cd8c View commit details
    Browse the repository at this point in the history

  30. Renamed State to BufferState for clarity 

    Event buffer's state should not clash with State concept
    @alice-i-cecile
    alice-i-cecile committed May 8, 2021
    Configuration menu
    Copy the full SHA
    ac56e12 View commit details
    Browse the repository at this point in the history

  31. Added comments explaining need for tiny map functions

    @alice-i-cecile
    alice-i-cecile committed May 8, 2021
    Configuration menu
    Copy the full SHA
    44e8dcb View commit details
    Browse the repository at this point in the history

  32. Fixed fetch for EventReader 

    Thanks @TheRawMeatball
    @alice-i-cecile
    alice-i-cecile committed May 8, 2021
    Configuration menu
    Copy the full SHA
    b454712 View commit details
    Browse the repository at this point in the history

  33. Added EventConsumer 

    Also added handy drain_with_id method
    @alice-i-cecile
    alice-i-cecile committed May 8, 2021
    Configuration menu
    Copy the full SHA
    a4fa818 View commit details
    Browse the repository at this point in the history

  34. Added EventConsumer example

    @alice-i-cecile
    alice-i-cecile committed May 8, 2021
    Configuration menu
    Copy the full SHA
    88052f3 View commit details
    Browse the repository at this point in the history

  35. Cleaned up example by organizing code into modules

    @alice-i-cecile
    alice-i-cecile committed May 8, 2021
    Configuration menu
    Copy the full SHA
    feb3d37 View commit details
    Browse the repository at this point in the history

  36. Added test for Event* as system parameters

    @alice-i-cecile
    alice-i-cecile committed May 8, 2021
    Configuration menu
    Copy the full SHA
    cd4b83c View commit details
    Browse the repository at this point in the history

  37. Moved back to #[derive(SystemParam)]

    @alice-i-cecile
    alice-i-cecile committed May 8, 2021
    Configuration menu
    Copy the full SHA
    3c8eb92 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2021

  1. Revert "Clean up on Examples README" 

    This reverts commit 525ccd5.
    @alice-i-cecile
    alice-i-cecile committed May 11, 2021
    Configuration menu
    Copy the full SHA
    f8a36c1 View commit details
    Browse the repository at this point in the history

  2. Add per-entity-events example to README.md

    @alice-i-cecile
    alice-i-cecile committed May 11, 2021
    Configuration menu
    Copy the full SHA
    2e31afd View commit details
    Browse the repository at this point in the history